Re: [PATCH v3 2/3] staging: iio: ad7780: update voltage on read

2018-11-03 Thread Jonathan Cameron
On Sat, 3 Nov 2018 13:06:19 -0300 Renato Lui Geh wrote: > On Thu, 1 Nov 2018 15:20:55 + > "Ardelean, Alexandru" wrote: > > > > This looks wrong. > > I admit this was done in the same way in the probe function, but that looks > > a bit wrong as well. > > > > Typically, the return value of `re

Re: [PATCH v3 2/3] staging: iio: ad7780: update voltage on read

2018-11-03 Thread Renato Lui Geh
On Thu, 1 Nov 2018 15:20:55 + "Ardelean, Alexandru" wrote: This looks wrong. I admit this was done in the same way in the probe function, but that looks a bit wrong as well. Typically, the return value of `regulator_get_voltage()` would get checked with: ret = regulator_get_voltage(st->re

Re: [PATCH v3 2/3] staging: iio: ad7780: update voltage on read

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 15:20:55 + "Ardelean, Alexandru" wrote: > On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > > The ad7780 driver previously did not read the correct device output, as > > it read an outdated value set at initialization. It now updates its > > voltage on read. > > >

Re: [PATCH v3 2/3] staging: iio: ad7780: update voltage on read

2018-11-01 Thread Ardelean, Alexandru
On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output, as > it read an outdated value set at initialization. It now updates its > voltage on read. > > Signed-off-by: Renato Lui Geh > --- > Changes in v3: > - removed in