Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2015-03-13 Thread Rob Herring
On Fri, Mar 6, 2015 at 12:59 PM, Peter Hurley wrote: > On 03/06/2015 01:11 PM, Peter Hurley wrote: >> On 03/06/2015 11:52 AM, Leif Lindholm wrote: > > [...] > >>> Could you give the below a spin, and if it works for you, send me the >>> above tests as a full patch so that I can post both as a seri

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2015-03-06 Thread Peter Hurley
On 03/06/2015 01:11 PM, Peter Hurley wrote: > On 03/06/2015 11:52 AM, Leif Lindholm wrote: [...] >> Could you give the below a spin, and if it works for you, send me the >> above tests as a full patch so that I can post both as a series? > > Will do as soon as I finish testing. All passed with

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2015-03-06 Thread Peter Hurley
On 03/06/2015 11:52 AM, Leif Lindholm wrote: > Hi Peter, > > On Wed, Mar 04, 2015 at 10:45:02AM -0500, Peter Hurley wrote: >> The path parsing gets lost if the string after ':' contains '/'. > > Doh! Hardly. I only noticed because I had to implement the corresponding algorithm for earlycon and

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2015-03-06 Thread Leif Lindholm
Hi Peter, On Wed, Mar 04, 2015 at 10:45:02AM -0500, Peter Hurley wrote: > The path parsing gets lost if the string after ':' contains '/'. Doh! Thanks for reporting (and sorry for slow response). > The selftests below fail with: > [1.365528] ### dt-test ### FAIL of_selftest_find_node_by_name

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2015-03-04 Thread Peter Hurley
Hi Leif, On 11/27/2014 12:56 PM, Leif Lindholm wrote: > Update of_find_node_by_path(): > 1) Rename function to of_find_node_opts_by_path(), adding an optional >pointer argument. Provide a static inline wrapper version of >of_find_node_by_path() which calls the new function with NULL as >

Re: [PATCH v3 2/3] of: add optional options parameter to? of_find_node_by_path()

2014-11-28 Thread Grant Likely
On Fri, Nov 28, 2014 at 4:38 PM, Leif Lindholm wrote: > On Fri, Nov 28, 2014 at 03:25:12PM +, Grant Likely wrote: >> On Fri, 28 Nov 2014 11:34:28 + >> , Leif Lindholm >> wrote: >> > On Fri, Nov 28, 2014 at 12:44:03AM +, Grant Likely wrote: >> > > > + separator = strchr(path, ':

Re: [PATCH v3 2/3] of: add optional options parameter to? of_find_node_by_path()

2014-11-28 Thread Leif Lindholm
On Fri, Nov 28, 2014 at 03:25:12PM +, Grant Likely wrote: > On Fri, 28 Nov 2014 11:34:28 + > , Leif Lindholm > wrote: > > On Fri, Nov 28, 2014 at 12:44:03AM +, Grant Likely wrote: > > > > + separator = strchr(path, ':'); > > > > + if (separator && opts) > > > > +

Re: Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2014-11-28 Thread Grant Likely
On Fri, Nov 28, 2014 at 3:25 PM, Grant Likely wrote: > On Fri, 28 Nov 2014 11:34:28 + > , Leif Lindholm > wrote: >> On Fri, Nov 28, 2014 at 12:44:03AM +, Grant Likely wrote: >> > > + separator = strchr(path, ':'); >> > > + if (separator && opts) >> > > + *opts = separator + 1; >>

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2014-11-28 Thread Grant Likely
On Fri, 28 Nov 2014 11:34:28 + , Leif Lindholm wrote: > On Fri, Nov 28, 2014 at 12:44:03AM +, Grant Likely wrote: > > > + separator = strchr(path, ':'); > > > + if (separator && opts) > > > + *opts = separator + 1; > > > + > > > > What about when there are no opts? Do we require

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2014-11-28 Thread Leif Lindholm
On Fri, Nov 28, 2014 at 12:44:03AM +, Grant Likely wrote: > On Thu, 27 Nov 2014 17:56:06 + > , Leif Lindholm > wrote: > > Update of_find_node_by_path(): > > 1) Rename function to of_find_node_opts_by_path(), adding an optional > >pointer argument. Provide a static inline wrapper versi

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2014-11-27 Thread Grant Likely
On Thu, 27 Nov 2014 17:56:06 + , Leif Lindholm wrote: > Update of_find_node_by_path(): > 1) Rename function to of_find_node_opts_by_path(), adding an optional >pointer argument. Provide a static inline wrapper version of >of_find_node_by_path() which calls the new function with NULL a