Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 16:35:41 +0100 Dan O'Donovan wrote: > From: Nicola Lunghi > > ACPI _HID AANT1280 matches an ADC124S101 present on E3940 SKUs of the UP > Squared board. > > Add it to the driver. > > Signed-off-by: Nicola Lunghi > [jav...@emutex.com: fix up commit message and one checkpatc

Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-28 Thread Jonathan Cameron
On Sat, 27 Oct 2018 22:44:28 +0530 Himanshu Jha wrote: > Hi Dan, > > On Thu, Oct 25, 2018 at 04:35:41PM +0100, Dan O'Donovan wrote: > > From: Nicola Lunghi > > > > ACPI _HID AANT1280 matches an ADC124S101 present on E3940 SKUs of the UP > > Squared board. > > > > Add it to the driver. > > >

Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-27 Thread Himanshu Jha
Hi Dan, On Thu, Oct 25, 2018 at 04:35:41PM +0100, Dan O'Donovan wrote: > From: Nicola Lunghi > > ACPI _HID AANT1280 matches an ADC124S101 present on E3940 SKUs of the UP > Squared board. > > Add it to the driver. > > Signed-off-by: Nicola Lunghi > [jav...@emutex.com: fix up commit message and

Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-26 Thread Andy Shevchenko
On Fri, Oct 26, 2018 at 11:13:01AM +0100, Dan O'Donovan wrote: > On 10/25/2018 06:46 PM, Andy Shevchenko wrote: > > On Thu, Oct 25, 2018 at 04:35:41PM +0100, Dan O'Donovan wrote: > >> + { "AANT1280", 2 }, /* ADC124S021 compatible ACPI ID */ > > Looking how driver is organized and what ACPI can p

Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-26 Thread Dan O'Donovan
On 10/25/2018 06:46 PM, Andy Shevchenko wrote: > On Thu, Oct 25, 2018 at 04:35:41PM +0100, Dan O'Donovan wrote: >> From: Nicola Lunghi >> >> ACPI _HID AANT1280 matches an ADC124S101 present on E3940 SKUs of the UP >> Squared board. >> >> Add it to the driver. >> >> Signed-off-by: Nicola Lunghi

Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-25 Thread Andy Shevchenko
On Thu, Oct 25, 2018 at 04:35:41PM +0100, Dan O'Donovan wrote: > From: Nicola Lunghi > > ACPI _HID AANT1280 matches an ADC124S101 present on E3940 SKUs of the UP > Squared board. > > Add it to the driver. > > Signed-off-by: Nicola Lunghi > [jav...@emutex.com: fix up commit message and one chec