RE: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-02 Thread matthew . gerlach
On Wed, 2 Dec 2020, Wu, Hao wrote: + } + + offset = dfl_res & PCI_VNDR_DFLS_RES_OFF_MASK; + if (offset >= len) { + dev_err(&pcidev->dev, "%s bad offset %u >= %pa\n", + __func__, offset, &len); +

RE: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-02 Thread matthew . gerlach
On Wed, 2 Dec 2020, Wu, Hao wrote: Subject: Re: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability Hi Matthew, On Mon, Nov 30, 2020 at 04:45:20PM -0800, matthew.gerl...@linux.intel.com wrote: On Sat, 28 Nov 2020, Wu, Hao wrote: Subject: [PATCH v3 2/2] fpga: dfl: look for

RE: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-02 Thread Wu, Hao
> Subject: Re: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability > > Hi Matthew, > > On Mon, Nov 30, 2020 at 04:45:20PM -0800, > matthew.gerl...@linux.intel.com wrote: > > > > > > On Sat, 28 Nov 2020, Wu, Hao wrote: > > > > > &

RE: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-02 Thread Wu, Hao
> > > > > > > > > + } > > > > > + > > > > > + offset = dfl_res & PCI_VNDR_DFLS_RES_OFF_MASK; > > > > > + if (offset >= len) { > > > > > + dev_err(&pcidev->dev, "%s bad > offset %u >= %pa\n", > > > > > + __func__, of

Re: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-01 Thread Xu Yilun
> > > > > > > + } > > > > + > > > > + offset = dfl_res & PCI_VNDR_DFLS_RES_OFF_MASK; > > > > + if (offset >= len) { > > > > + dev_err(&pcidev->dev, "%s bad offset %u >= > > > > %pa\n", > > > > + __func__

Re: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-01 Thread Moritz Fischer
Hi Matthew, On Mon, Nov 30, 2020 at 04:45:20PM -0800, matthew.gerl...@linux.intel.com wrote: > > > On Sat, 28 Nov 2020, Wu, Hao wrote: > > > > Subject: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability > > > > Maybe we can change the title a little bit, what about > > fpga: dfl-pci

RE: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-11-30 Thread matthew . gerlach
On Sat, 28 Nov 2020, Wu, Hao wrote: Subject: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability Maybe we can change the title a little bit, what about fpga: dfl-pci: locate DFLs by PCIe vendor specific capability From: Matthew Gerlach A DFL may not begin at offset 0 of BAR 0