Re: [PATCH v3 2/2] dmaengine: sprd: Add Spreadtrum DMA configuration

2018-05-16 Thread Baolin Wang
On 17 May 2018 at 14:11, Vinod wrote: > On 17-05-18, 14:02, Baolin Wang wrote: >> Hi Vinod, >> >> On 17 May 2018 at 13:14, Vinod wrote: >> > On 11-05-18, 21:06, Baolin Wang wrote: >> >> +struct sprd_dma_config { >> >> + struct dma_slave_config cfg; >> >> + u32 block_len; >> >> + u32 t

Re: [PATCH v3 2/2] dmaengine: sprd: Add Spreadtrum DMA configuration

2018-05-16 Thread Vinod
On 17-05-18, 14:02, Baolin Wang wrote: > Hi Vinod, > > On 17 May 2018 at 13:14, Vinod wrote: > > On 11-05-18, 21:06, Baolin Wang wrote: > >> +struct sprd_dma_config { > >> + struct dma_slave_config cfg; > >> + u32 block_len; > >> + u32 transcation_len; > > > > /s/transcation/transacti

Re: [PATCH v3 2/2] dmaengine: sprd: Add Spreadtrum DMA configuration

2018-05-16 Thread Baolin Wang
Hi Vinod, On 17 May 2018 at 13:14, Vinod wrote: > On 11-05-18, 21:06, Baolin Wang wrote: >> +struct sprd_dma_config { >> + struct dma_slave_config cfg; >> + u32 block_len; >> + u32 transcation_len; > > /s/transcation/transaction OK. > > now in code I see block_len and this filled by

Re: [PATCH v3 2/2] dmaengine: sprd: Add Spreadtrum DMA configuration

2018-05-16 Thread Vinod
On 11-05-18, 21:06, Baolin Wang wrote: > +struct sprd_dma_config { > + struct dma_slave_config cfg; > + u32 block_len; > + u32 transcation_len; /s/transcation/transaction now in code I see block_len and this filled by len which is sg_dma_len()? So why two varibales when you are using