Re: [PATCH v3 2/2] ARM: ftrace: Add MODULE_PLTS support

2018-03-09 Thread Ard Biesheuvel
On 9 March 2018 at 08:54, Alexander Sverdlin wrote: > Hello Ard! > > On 09/03/18 09:50, Ard Biesheuvel wrote: >>> +static u32 fixed_plts[] = { >>> + FTRACE_ADDR, >>> + MCOUNT_ADDR, >>> +#ifdef CONFIG_OLD_MCOUNT >>> + (unsigned long)ftrace_caller_old, >>> + (unsigned long)mc

Re: [PATCH v3 2/2] ARM: ftrace: Add MODULE_PLTS support

2018-03-09 Thread Alexander Sverdlin
Hello Ard! On 09/03/18 09:50, Ard Biesheuvel wrote: >> +static u32 fixed_plts[] = { >> + FTRACE_ADDR, >> + MCOUNT_ADDR, >> +#ifdef CONFIG_OLD_MCOUNT >> + (unsigned long)ftrace_caller_old, >> + (unsigned long)mcount, >> +#endif >> +}; >> + > Do we need this stuff in the PLT

Re: [PATCH v3 2/2] ARM: ftrace: Add MODULE_PLTS support

2018-03-09 Thread Ard Biesheuvel
Hi Alexander, On 9 March 2018 at 08:41, Alexander Sverdlin wrote: > Teach ftrace_make_call() and ftrace_make_nop() about PLTs. > Teach PLT code about FTRACE and all its callbacks. > Otherwise the following might happen: > > [ cut here ] > WARNING: CPU: 14 PID: 2265 at .../