Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014年09月23日 15:48, Daniel Vetter wrote: On Mon, Sep 22, 2014 at 09:32:19AM +0800, Mark yao wrote: On 2014年09月20日 08:03, Rob Clark wrote: On Fri, Sep 19, 2014 at 1:47 AM, Mark yao wrote: diff --git a/include/uapi/drm/rockchip_drm.h b/include/uapi/drm/rockchip_drm.h new file mode 100644 inde

Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Daniel Vetter
On Mon, Sep 22, 2014 at 09:32:19AM +0800, Mark yao wrote: > On 2014年09月20日 08:03, Rob Clark wrote: > >On Fri, Sep 19, 2014 at 1:47 AM, Mark yao wrote: > >>diff --git a/include/uapi/drm/rockchip_drm.h > >>b/include/uapi/drm/rockchip_drm.h > >>new file mode 100644 > >>index 000..8f8e60e > >>---

Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-21 Thread Mark yao
On 2014年09月20日 08:03, Rob Clark wrote: On Fri, Sep 19, 2014 at 1:47 AM, Mark yao wrote: diff --git a/include/uapi/drm/rockchip_drm.h b/include/uapi/drm/rockchip_drm.h new file mode 100644 index 000..8f8e60e --- /dev/null +++ b/include/uapi/drm/rockchip_drm.h @@ -0,0 +1,97 @@ +/* + * + * Cop

Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-21 Thread Mark yao
On 2014年09月19日 21:04, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 7:47 AM, Mark yao wrote: [snip] +static int rockchip_drm_bind(struct device *dev) +{ + return drm_platform_init(&rockchip_drm_driver, to_platform_device(dev)); Please avoid drm_platform_*() usage. We're about to drop

Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-19 Thread Rob Clark
On Fri, Sep 19, 2014 at 1:47 AM, Mark yao wrote: > diff --git a/include/uapi/drm/rockchip_drm.h b/include/uapi/drm/rockchip_drm.h > new file mode 100644 > index 000..8f8e60e > --- /dev/null > +++ b/include/uapi/drm/rockchip_drm.h > @@ -0,0 +1,97 @@ > +/* > + * > + * Copyright (c) Fuzhou Rockch

Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 7:47 AM, Mark yao wrote: [snip] > +static int rockchip_drm_bind(struct device *dev) > +{ > + return drm_platform_init(&rockchip_drm_driver, > to_platform_device(dev)); Please avoid drm_platform_*() usage. We're about to drop all the drm_bus midlayers. See the te