Re: [linux-sunxi] Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-10 Thread Maxime Ripard
Hi, On Wed, Feb 10, 2016 at 08:17:14AM +0100, Krzysztof Adamski wrote: > On Tue, Feb 09, 2016 at 06:10:40PM +0100, Maxime Ripard wrote: > It seems that the other compatible strings are there for historical > reasons. Why do you need a new one with such a specific name? > > It woul

Re: [linux-sunxi] Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-09 Thread Krzysztof Adamski
On Tue, Feb 09, 2016 at 06:10:40PM +0100, Maxime Ripard wrote: >>It seems that the other compatible strings are there for historical >>reasons. Why do you need a new one with such a specific name? >> >>It would have been more sensible to add a generic compatible string as >>"allwinner,apb-gates",

Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-09 Thread Maxime Ripard
On Sat, Feb 06, 2016 at 11:26:05AM +0100, Jean-Francois Moine wrote: > On Fri, 5 Feb 2016 12:11:52 +0100 > Maxime Ripard wrote: > > > However, I'd like to keep per-soc and per-clocks compatibles in the > > DT, in case we need to protect a clock in the future. > > What do you mean by "protect a c

Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-09 Thread Maxime Ripard
On Fri, Feb 05, 2016 at 12:58:37PM +0100, Krzysztof Adamski wrote: > On Fri, Feb 05, 2016 at 12:11:52PM +0100, Maxime Ripard wrote: > >Hi, > > > >On Thu, Feb 04, 2016 at 03:47:52PM +0100, Jean-Francois Moine wrote: > >>On Thu, 4 Feb 2016 00:33:46 +0100 > >>Krzysztof Adamski wrote: > >> > >>> This

Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-06 Thread Jean-Francois Moine
On Fri, 5 Feb 2016 12:11:52 +0100 Maxime Ripard wrote: > However, I'd like to keep per-soc and per-clocks compatibles in the > DT, in case we need to protect a clock in the future. What do you mean by "protect a clock"? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef

Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-05 Thread Krzysztof Adamski
On Fri, Feb 05, 2016 at 12:11:52PM +0100, Maxime Ripard wrote: Hi, On Thu, Feb 04, 2016 at 03:47:52PM +0100, Jean-Francois Moine wrote: On Thu, 4 Feb 2016 00:33:46 +0100 Krzysztof Adamski wrote: > This patch adds support for APB0 in H3. It seems to be compatible with > earlier SOCs. apb0 gat

Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-05 Thread Maxime Ripard
Hi, On Thu, Feb 04, 2016 at 09:56:02PM +0100, Krzysztof Adamski wrote: > On Thu, Feb 04, 2016 at 03:47:52PM +0100, Jean-Francois Moine wrote: > >On Thu, 4 Feb 2016 00:33:46 +0100 > >Krzysztof Adamski wrote: > > > >>This patch adds support for APB0 in H3. It seems to be compatible with > >>earlie

Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-05 Thread Maxime Ripard
Hi, On Thu, Feb 04, 2016 at 03:47:52PM +0100, Jean-Francois Moine wrote: > On Thu, 4 Feb 2016 00:33:46 +0100 > Krzysztof Adamski wrote: > > > This patch adds support for APB0 in H3. It seems to be compatible with > > earlier SOCs. apb0 gates controls R_ block peripherals (R_PIO, R_IR, > > etc).

Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-04 Thread Krzysztof Adamski
On Thu, Feb 04, 2016 at 03:47:52PM +0100, Jean-Francois Moine wrote: On Thu, 4 Feb 2016 00:33:46 +0100 Krzysztof Adamski wrote: This patch adds support for APB0 in H3. It seems to be compatible with earlier SOCs. apb0 gates controls R_ block peripherals (R_PIO, R_IR, etc). Signed-off-by: Krz

Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3

2016-02-04 Thread Jean-Francois Moine
On Thu, 4 Feb 2016 00:33:46 +0100 Krzysztof Adamski wrote: > This patch adds support for APB0 in H3. It seems to be compatible with > earlier SOCs. apb0 gates controls R_ block peripherals (R_PIO, R_IR, > etc). > > Signed-off-by: Krzysztof Adamski > --- > Documentation/devicetree/bindings/clo