Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-12-22 Thread Pratyush Anand
Hi Dave, On Tue, Nov 18, 2014 at 12:02 PM, David Long wrote: > From: Sandeepa Prabhu > > Add support for basic kernel probes(kprobes) and jump probes > (jprobes) for ARM64. Some part of the code can be reused for uprobes as well. I think, there would still be next revision. So, if you can re-fa

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-26 Thread Will Deacon
On Wed, Nov 26, 2014 at 06:46:12AM +, David Long wrote: > On 11/19/14 09:55, David Long wrote: > > On 11/19/14 06:25, Will Deacon wrote: > >> I was thinking of the magic hex numbers in the kprobes decode tables, > >> which > >> seem to correspond directly to the instruction classes described in

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-25 Thread David Long
On 11/19/14 09:55, David Long wrote: On 11/19/14 06:25, Will Deacon wrote: On Wed, Nov 19, 2014 at 11:21:24AM +, Sandeepa Prabhu wrote: On 18 November 2014 20:26, Will Deacon wrote: One thing I noticed looking through this patch is that we're effectively reinventing a bunch of the instru

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-20 Thread David Long
On 11/18/14 08:28, Jon Medhurst (Tixy) wrote: On Tue, 2014-11-18 at 01:32 -0500, David Long wrote: From: Sandeepa Prabhu Add support for basic kernel probes(kprobes) and jump probes (jprobes) for ARM64. Kprobes will utilize software breakpoint and single step debug exceptions supported on ARM

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-19 Thread Sandeepa Prabhu
On 19 November 2014 20:25, David Long wrote: >> I was thinking of the magic hex numbers in the kprobes decode tables, >> which >> seem to correspond directly to the instruction classes described in insn.c >> >> Keeping the actual emulation code separate makes sense. >> >> Will > > > Of course that

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-19 Thread David Long
On 11/19/14 06:25, Will Deacon wrote: On Wed, Nov 19, 2014 at 11:21:24AM +, Sandeepa Prabhu wrote: On 18 November 2014 20:26, Will Deacon wrote: One thing I noticed looking through this patch is that we're effectively reinventing a bunch of the instruction decoding logic that we already h

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-19 Thread Will Deacon
On Wed, Nov 19, 2014 at 11:21:24AM +, Sandeepa Prabhu wrote: > On 18 November 2014 20:26, Will Deacon wrote: > > > One thing I noticed looking through this patch is that we're effectively > > reinventing a bunch of the instruction decoding logic that we already have > > in the kernel (introdu

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-19 Thread Sandeepa Prabhu
On 18 November 2014 20:26, Will Deacon wrote: > One thing I noticed looking through this patch is that we're effectively > reinventing a bunch of the instruction decoding logic that we already have > in the kernel (introduced since Sandeepa last sent his patch). > > Could you take a look at inclu

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-18 Thread Will Deacon
Hello, On Tue, Nov 18, 2014 at 06:32:51AM +, David Long wrote: > From: Sandeepa Prabhu > > Add support for basic kernel probes(kprobes) and jump probes > (jprobes) for ARM64. > > Kprobes will utilize software breakpoint and single step debug > exceptions supported on ARM v8. > > software b

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-18 Thread William Cohen
On 11/18/2014 01:32 AM, David Long wrote: > From: Sandeepa Prabhu > > Add support for basic kernel probes(kprobes) and jump probes > (jprobes) for ARM64. > > Kprobes will utilize software breakpoint and single step debug > exceptions supported on ARM v8. > > software breakpoint is placed at the

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-18 Thread William Cohen
On 11/18/2014 01:32 AM, David Long wrote: > From: Sandeepa Prabhu > > Add support for basic kernel probes(kprobes) and jump probes > (jprobes) for ARM64. > > Kprobes will utilize software breakpoint and single step debug > exceptions supported on ARM v8. > > software breakpoint is placed at the

Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support

2014-11-18 Thread Jon Medhurst (Tixy)
On Tue, 2014-11-18 at 01:32 -0500, David Long wrote: > From: Sandeepa Prabhu > > Add support for basic kernel probes(kprobes) and jump probes > (jprobes) for ARM64. > > Kprobes will utilize software breakpoint and single step debug > exceptions supported on ARM v8. > > software breakpoint is pl