Re: [PATCH v3 1/3] sched: Stop nohz stats when decayed

2018-02-12 Thread Vincent Guittot
On 12 February 2018 at 11:45, Peter Zijlstra wrote: > On Mon, Feb 12, 2018 at 09:07:52AM +0100, Vincent Guittot wrote: >> @@ -9383,11 +9450,16 @@ static bool nohz_idle_balance(struct rq *this_rq, >> enum cpu_idle_type idle) >>* work being done for other cpus. Next load >>

Re: [PATCH v3 1/3] sched: Stop nohz stats when decayed

2018-02-12 Thread Peter Zijlstra
On Mon, Feb 12, 2018 at 09:07:52AM +0100, Vincent Guittot wrote: > @@ -9383,11 +9450,16 @@ static bool nohz_idle_balance(struct rq *this_rq, > enum cpu_idle_type idle) >* work being done for other cpus. Next load >* balancing owner will pick it up. >

Re: [PATCH v3 1/3] sched: Stop nohz stats when decayed

2018-02-12 Thread Vincent Guittot
On 12 February 2018 at 10:41, Peter Zijlstra wrote: > On Mon, Feb 12, 2018 at 09:07:52AM +0100, Vincent Guittot wrote: >> @@ -9222,6 +9259,20 @@ void nohz_balance_enter_idle(int cpu) >> atomic_inc(&nohz.nr_cpus); >> >> set_cpu_sd_state_idle(cpu); >> + >> + /* >> + * Ensures

Re: [PATCH v3 1/3] sched: Stop nohz stats when decayed

2018-02-12 Thread Peter Zijlstra
On Mon, Feb 12, 2018 at 09:07:52AM +0100, Vincent Guittot wrote: > @@ -9222,6 +9259,20 @@ void nohz_balance_enter_idle(int cpu) > atomic_inc(&nohz.nr_cpus); > > set_cpu_sd_state_idle(cpu); > + > + /* > + * Ensures that if nohz_idle_balance() fails to observe our > +