Re: [PATCH v3 1/3] overflow.h: Add arithmetic shift helper

2018-08-01 Thread Kees Cook
On Wed, Aug 1, 2018 at 9:28 AM, Randy Dunlap wrote: > On 07/31/2018 11:09 PM, Kees Cook wrote: >> From: Jason Gunthorpe >> >> Add shift_overflow() helper to assist driver authors in ensuring that >> shift operations don't cause overflows or other odd conditions. >> >> Signed-off-by: Jason Gunthor

Re: [PATCH v3 1/3] overflow.h: Add arithmetic shift helper

2018-08-01 Thread Randy Dunlap
On 07/31/2018 11:09 PM, Kees Cook wrote: > From: Jason Gunthorpe > > Add shift_overflow() helper to assist driver authors in ensuring that > shift operations don't cause overflows or other odd conditions. > > Signed-off-by: Jason Gunthorpe > Signed-off-by: Leon Romanovsky > [kees: tweaked comm