Re: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-18 Thread Johannes Thumshirn
On Thu, Jan 18, 2018 at 04:21:34PM +0100, Christoph Hellwig wrote: > On Wed, Jan 17, 2018 at 11:53:35AM +0100, Johannes Thumshirn wrote: > > +nvme-core-y:= trace.o core.o > > trace.o should be conditional on CONFIG_TRACEPOINTS. Doesn't do too much of a difference

Re: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-18 Thread Christoph Hellwig
On Wed, Jan 17, 2018 at 11:53:35AM +0100, Johannes Thumshirn wrote: > +nvme-core-y := trace.o core.o trace.o should be conditional on CONFIG_TRACEPOINTS. > +TRACE_EVENT(nvme_setup_cmd, > + TP_PROTO(struct nvme_command *cmd), > + TP_ARGS(cmd), > + T

Re: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-17 Thread Keith Busch
Looks good. Reviewed-by: Keith Busch

Re: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-17 Thread Martin K. Petersen
Johannes, Very nice! Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering