Re: [PATCH v3 1/2] mfd: rtsx: reduce code duplication in rtl8411

2013-12-17 Thread micky
On 12/17/2013 03:28 PM, Dan Carpenter wrote: On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ch...@realsil.com.cn wrote: diff --git a/drivers/mfd/rtsx_pcr.h b/drivers/mfd/rtsx_pcr.h index 947e79b..26b52ec 100644 --- a/drivers/mfd/rtsx_pcr.h +++ b/drivers/mfd/rtsx_pcr.h @@ -63,4 +63,12 @@ static

Re: [PATCH v3 1/2] mfd: rtsx: reduce code duplication in rtl8411

2013-12-17 Thread Dan Carpenter
On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ch...@realsil.com.cn wrote: > void rtl8411b_init_params(struct rtsx_pcr *pcr) > { > - pcr->extra_caps = EXTRA_CAPS_SD_SDR50 | EXTRA_CAPS_SD_SDR104; > - pcr->num_slots = 2; > - pcr->ops = &rtl8411b_pcr_ops; > - > - pcr->flags = 0; > -

Re: [PATCH v3 1/2] mfd: rtsx: reduce code duplication in rtl8411

2013-12-16 Thread Dan Carpenter
On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ch...@realsil.com.cn wrote: > diff --git a/drivers/mfd/rtsx_pcr.h b/drivers/mfd/rtsx_pcr.h > index 947e79b..26b52ec 100644 > --- a/drivers/mfd/rtsx_pcr.h > +++ b/drivers/mfd/rtsx_pcr.h > @@ -63,4 +63,12 @@ static inline u8 map_sd_drive(int idx) > #de