Re: [PATCH v3 1/2] eeprom: at24: fix coding style issues

2017-12-10 Thread Joe Perches
On Sun, 2017-12-10 at 19:42 +0100, Bartosz Golaszewski wrote: > 2017-12-10 13:57 GMT+01:00 Andy Shevchenko : > > On Thu, Dec 7, 2017 at 3:39 PM, Bartosz Golaszewski wrote: > > > Fix issues reported by checkpatch for at24.c. > > > +module_param(io_limit, uint, ); > > > +module_param(write_timeo

Re: [PATCH v3 1/2] eeprom: at24: fix coding style issues

2017-12-10 Thread Bartosz Golaszewski
2017-12-10 13:57 GMT+01:00 Andy Shevchenko : > On Thu, Dec 7, 2017 at 3:39 PM, Bartosz Golaszewski wrote: >> Fix issues reported by checkpatch for at24.c. > >> +module_param(io_limit, uint, ); > >> +module_param(write_timeout, uint, ); > > > 0 is a pretty much octal number as . > So, I

Re: [PATCH v3 1/2] eeprom: at24: fix coding style issues

2017-12-10 Thread Andy Shevchenko
On Thu, Dec 7, 2017 at 3:39 PM, Bartosz Golaszewski wrote: > Fix issues reported by checkpatch for at24.c. > +module_param(io_limit, uint, ); > +module_param(write_timeout, uint, ); 0 is a pretty much octal number as . So, I would prefer not to blindly follow the stupid advise from

Re: [PATCH v3 1/2] eeprom: at24: fix coding style issues

2017-12-10 Thread Bartosz Golaszewski
2017-12-10 2:31 GMT+01:00 Christoph Böhmwalder : > On Thu, Dec 07, 2017 at 02:39:14PM +0100, Bartosz Golaszewski wrote: >> -#define AT24_DEVICE_MAGIC(_len, _flags) \ >> - ((1 << AT24_SIZE_FLAGS | (_flags)) \ >> +#define AT24_DEVICE_MAGIC(_len, _flags)

Re: [PATCH v3 1/2] eeprom: at24: fix coding style issues

2017-12-09 Thread Christoph Böhmwalder
On Thu, Dec 07, 2017 at 02:39:14PM +0100, Bartosz Golaszewski wrote: > -#define AT24_DEVICE_MAGIC(_len, _flags) \ > - ((1 << AT24_SIZE_FLAGS | (_flags)) \ > +#define AT24_DEVICE_MAGIC(_len, _flags) \ > + ((1 << AT24_SIZE_FLAGS | (_flags))