Re: [PATCH v3 1/1] Input: serio - Add ARC PS/2 driver

2012-10-18 Thread Joe Perches
On Thu, 2012-10-18 at 09:05 +, Mischa Jonker wrote: > Hi Joe, > > >> + while (1) { > >infinite loop with bad hardware? > >Perhaps a jiffies timeout? > > What do you suggest? Add a counter and limit the maximum number of iterations > to an arbitrary number (say 1000)? Yes, something like th

RE: [PATCH v3 1/1] Input: serio - Add ARC PS/2 driver

2012-10-18 Thread Mischa Jonker
Hi Joe, >> +while (1) { >infinite loop with bad hardware? >Perhaps a jiffies timeout? What do you suggest? Add a counter and limit the maximum number of iterations to an arbitrary number (say 1000)? Mischa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [PATCH v3 1/1] Input: serio - Add ARC PS/2 driver

2012-10-18 Thread Joe Perches
On Thu, 2012-10-18 at 10:36 +0200, Mischa Jonker wrote: > This adds support for the PS/2 block that is used in various ARC FPGA > platforms. [] > diff --git a/drivers/input/serio/arc_ps2.c b/drivers/input/serio/arc_ps2.c [] > +static void arc_ps2_check_rx(struct arc_ps2_data *arc_ps2, > +