Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-24 Thread Pratyush Anand
Hi Mark, James and Will, What is the take on this series? Just to summarize: - James took first three patches of the series and replaced 4th and 5th patch with his 3 patch series [3]. - My patchset disables interrupt while exiting from HW breakpoint/watchpoint and SW breakpoint handlers, and

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-03 Thread James Morse
Hi Pratyush, On 02/08/17 19:46, Pratyush Anand wrote: > In my understanding problems are: > (1) Single stepping of unwanted instruction (ie. instruction next to > enable_dbg > from el1_irq) > (2) We do not have memory at the end of el1_irq, so that we can set watchpoint > exception generating in

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-02 Thread Pratyush Anand
Hi James, Thanks for your analysis. On Wednesday 02 August 2017 10:43 PM, James Morse wrote: Hi Pratyush, On 01/08/17 05:18, Pratyush Anand wrote: On Monday 31 July 2017 10:45 PM, James Morse wrote: On 31/07/17 11:40, Pratyush Anand wrote: samples/hw_breakpoint/data_breakpoint.c passes with

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-02 Thread James Morse
Hi Pratyush, On 01/08/17 05:18, Pratyush Anand wrote: > On Monday 31 July 2017 10:45 PM, James Morse wrote: >> On 31/07/17 11:40, Pratyush Anand wrote: >>> samples/hw_breakpoint/data_breakpoint.c passes with x86_64 but fails with >>> ARM64. Even though it has been NAKed previously on upstream [1,

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-01 Thread Pratyush Anand
Hi Takahiro, On Tuesday 01 August 2017 01:44 PM, AKASHI Takahiro wrote: Hi Pratyush, On Mon, Jul 31, 2017 at 04:10:28PM +0530, Pratyush Anand wrote: v2 -> v3 - Moved step_needed from uapi structure to kernel only structure - Re-enable interrupt if stepped instruction faults - Modified register

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-08-01 Thread AKASHI Takahiro
Hi Pratyush, On Mon, Jul 31, 2017 at 04:10:28PM +0530, Pratyush Anand wrote: > v2 -> v3 > - Moved step_needed from uapi structure to kernel only structure > - Re-enable interrupt if stepped instruction faults > - Modified register_wide_hw_breakpoint() to accept step_needed arg > v2 was here: http:

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-07-31 Thread Pratyush Anand
Hi James, On Monday 31 July 2017 10:45 PM, James Morse wrote: Hi Pratyush, On 31/07/17 11:40, Pratyush Anand wrote: samples/hw_breakpoint/data_breakpoint.c passes with x86_64 but fails with ARM64. Even though it has been NAKed previously on upstream [1, 2], I have tried to come up with patches

Re: [PATCH v3 0/5] ARM64: disable irq between breakpoint and step exception

2017-07-31 Thread James Morse
Hi Pratyush, On 31/07/17 11:40, Pratyush Anand wrote: > samples/hw_breakpoint/data_breakpoint.c passes with x86_64 but fails with > ARM64. Even though it has been NAKed previously on upstream [1, 2], I have > tried to come up with patches which can resolve it for ARM64 as well. > > I noticed that