Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-11-01 Thread Jonathan Cameron
On 31/10/16 08:05, Eva Rachel Retuya wrote: > On Mon, Oct 31, 2016 at 03:49:01PM +0800, Eva Rachel Retuya wrote: >> On Sun, Oct 30, 2016 at 06:49:00PM +, Jonathan Cameron wrote: >>> On 30/10/16 17:46, Lars-Peter Clausen wrote: On 10/30/2016 06:41 PM, Jonathan Cameron wrote: > On 28/10/

Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-10-31 Thread Eva Rachel Retuya
On Mon, Oct 31, 2016 at 03:49:01PM +0800, Eva Rachel Retuya wrote: > On Sun, Oct 30, 2016 at 06:49:00PM +, Jonathan Cameron wrote: > > On 30/10/16 17:46, Lars-Peter Clausen wrote: > > > On 10/30/2016 06:41 PM, Jonathan Cameron wrote: > > >> On 28/10/16 09:26, Eva Rachel Retuya wrote: > > >>> In

Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-10-31 Thread Eva Rachel Retuya
On Sun, Oct 30, 2016 at 06:49:00PM +, Jonathan Cameron wrote: > On 30/10/16 17:46, Lars-Peter Clausen wrote: > > On 10/30/2016 06:41 PM, Jonathan Cameron wrote: > >> On 28/10/16 09:26, Eva Rachel Retuya wrote: > >>> Introduce defines for shifting and mask under the config register for > >>> bet

Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-10-30 Thread Jonathan Cameron
On 30/10/16 17:46, Lars-Peter Clausen wrote: > On 10/30/2016 06:41 PM, Jonathan Cameron wrote: >> On 28/10/16 09:26, Eva Rachel Retuya wrote: >>> Introduce defines for shifting and mask under the config register for >>> better readability. Also, introduce helper variables for index >>> calculation.

Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-10-30 Thread Lars-Peter Clausen
On 10/30/2016 06:41 PM, Jonathan Cameron wrote: > On 28/10/16 09:26, Eva Rachel Retuya wrote: >> Introduce defines for shifting and mask under the config register for >> better readability. Also, introduce helper variables for index >> calculation. >> >> Signed-off-by: Eva Rachel Retuya > Looks go

Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-10-30 Thread Jonathan Cameron
On 28/10/16 09:26, Eva Rachel Retuya wrote: > Introduce defines for shifting and mask under the config register for > better readability. Also, introduce helper variables for index > calculation. > > Signed-off-by: Eva Rachel Retuya Looks good to me. Lars could you sanity check this one as well?