Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-11-14 Thread Shawn N
Hi Jon, On Tue, Nov 14, 2017 at 7:56 AM, Jon Hunter wrote: > > Hi Shawn, > > On 26/09/17 16:40, Jon Hunter wrote: > > On 26/09/17 00:15, Shawn N wrote: > > ... > > >> From: Shawn Nematbakhsh > >> Date: Mon, 25 Sep 2017 14:32:38 -0700 > >> Subject: [PATCH] mfd: cros ec: spi: Fix "in progress" err

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-11-14 Thread Jon Hunter
Hi Shawn, On 26/09/17 16:40, Jon Hunter wrote: > On 26/09/17 00:15, Shawn N wrote: ... >> From: Shawn Nematbakhsh >> Date: Mon, 25 Sep 2017 14:32:38 -0700 >> Subject: [PATCH] mfd: cros ec: spi: Fix "in progress" error signaling >> >> For host commands that take a long time to process, cros ec c

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-11-08 Thread Doug Anderson
Hi, On Wed, Nov 8, 2017 at 2:20 AM, Jon Hunter wrote: > Hi Doug, > > On 07/11/17 17:22, Doug Anderson wrote: >> On Tue, Nov 7, 2017 at 3:28 AM, Jon Hunter wrote: >>> On 10/10/17 17:52, Doug Anderson wrote: >>> >>> ... >>> > I'm still not clear on why we see an error only on the first > t

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-11-08 Thread Jon Hunter
Hi Doug, On 07/11/17 17:22, Doug Anderson wrote: > On Tue, Nov 7, 2017 at 3:28 AM, Jon Hunter wrote: >> On 10/10/17 17:52, Doug Anderson wrote: >> >> ... >> I'm still not clear on why we see an error only on the first transaction after boot. In this case, the embedded controller pr

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-11-07 Thread Doug Anderson
Hi, On Tue, Nov 7, 2017 at 3:28 AM, Jon Hunter wrote: > > On 10/10/17 17:52, Doug Anderson wrote: > > ... > >>> I'm still not clear on why we see an error only on the first >>> transaction after boot. In this case, the embedded controller >>> previously handled host commands from firmware just fi

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-11-07 Thread Jon Hunter
On 10/10/17 17:52, Doug Anderson wrote: ... >> I'm still not clear on why we see an error only on the first >> transaction after boot. In this case, the embedded controller >> previously handled host commands from firmware just fine, and the >> handoff between firmware and the kernel shouldn't b

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-10-10 Thread Doug Anderson
Hi, On Tue, Oct 10, 2017 at 8:33 AM, Shawn N wrote: >> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi >> b/arch/arm/boot/dts/tegra124-nyan.dtsi >> index 5cf987b5401e..0baa6bfc0f36 100644 >> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi >> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi >> @@ -317,6 +

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-10-10 Thread Shawn N
On Tue, Oct 10, 2017 at 6:35 AM, Jon Hunter wrote: > > On 26/09/17 00:15, Shawn N wrote: >> On Wed, Sep 20, 2017 at 1:22 PM, Shawn N wrote: >>> On Tue, Sep 19, 2017 at 11:13 PM, Brian Norris >>> wrote: Hi, On Tue, Sep 19, 2017 at 11:05:38PM -0700, Shawn N wrote: > This is fai

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-10-10 Thread Jon Hunter
On 26/09/17 00:15, Shawn N wrote: > On Wed, Sep 20, 2017 at 1:22 PM, Shawn N wrote: >> On Tue, Sep 19, 2017 at 11:13 PM, Brian Norris >> wrote: >>> Hi, >>> >>> On Tue, Sep 19, 2017 at 11:05:38PM -0700, Shawn N wrote: This is failing because our EC_CMD_GET_PROTOCOL_INFO host command is

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-26 Thread Jon Hunter
On 26/09/17 00:15, Shawn N wrote: > On Wed, Sep 20, 2017 at 1:22 PM, Shawn N wrote: >> On Tue, Sep 19, 2017 at 11:13 PM, Brian Norris >> wrote: >>> Hi, >>> >>> On Tue, Sep 19, 2017 at 11:05:38PM -0700, Shawn N wrote: This is failing because our EC_CMD_GET_PROTOCOL_INFO host command is

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-25 Thread Shawn N
On Wed, Sep 20, 2017 at 1:22 PM, Shawn N wrote: > On Tue, Sep 19, 2017 at 11:13 PM, Brian Norris > wrote: >> Hi, >> >> On Tue, Sep 19, 2017 at 11:05:38PM -0700, Shawn N wrote: >>> This is failing because our EC_CMD_GET_PROTOCOL_INFO host command is >>> getting messed up, or the reply buffer is g

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-20 Thread Shawn N
On Tue, Sep 19, 2017 at 11:13 PM, Brian Norris wrote: > Hi, > > On Tue, Sep 19, 2017 at 11:05:38PM -0700, Shawn N wrote: >> This is failing because our EC_CMD_GET_PROTOCOL_INFO host command is >> getting messed up, or the reply buffer is getting corrupted somehow. >> >>ec_dev->prot

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-19 Thread Brian Norris
Hi, On Tue, Sep 19, 2017 at 11:05:38PM -0700, Shawn N wrote: > This is failing because our EC_CMD_GET_PROTOCOL_INFO host command is > getting messed up, or the reply buffer is getting corrupted somehow. > >ec_dev->proto_version = > min(EC_HOST_REQUEST_VERSI

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-19 Thread Shawn N
This is failing because our EC_CMD_GET_PROTOCOL_INFO host command is getting messed up, or the reply buffer is getting corrupted somehow. ec_dev->proto_version = min(EC_HOST_REQUEST_VERSION, fls(proto_info->protocol_ver

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-19 Thread Brian Norris
Hi Jon, On Tue, Sep 19, 2017 at 05:39:56PM +0100, Jon Hunter wrote: > On 19/09/17 15:09, Shawn N wrote: > > On Tue, Sep 19, 2017 at 6:44 AM, Jon Hunter wrote: > >> Tegra124 Nyan-Big is currently crashing during boot with -next [0] and > >> bisect is pointing to this commit. Reverting the above on

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-19 Thread Shawn N
On Tue, Sep 19, 2017 at 9:39 AM, Jon Hunter wrote: > > > On 19/09/17 15:09, Shawn N wrote: >> On Tue, Sep 19, 2017 at 6:44 AM, Jon Hunter wrote: >>> >>> Hi Brian, >>> >>> On 08/09/17 21:50, Brian Norris wrote: From: Shawn Nematbakhsh pkt_xfer should be used for protocol v3, and cm

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-19 Thread Jon Hunter
On 19/09/17 15:09, Shawn N wrote: > On Tue, Sep 19, 2017 at 6:44 AM, Jon Hunter wrote: >> >> Hi Brian, >> >> On 08/09/17 21:50, Brian Norris wrote: >>> From: Shawn Nematbakhsh >>> >>> pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had >>> one instance of these functions cor

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-19 Thread Shawn N
On Tue, Sep 19, 2017 at 6:44 AM, Jon Hunter wrote: > > Hi Brian, > > On 08/09/17 21:50, Brian Norris wrote: > > From: Shawn Nematbakhsh > > > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > > one instance of these functions correct, but not the second, fall-back > > ca

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-19 Thread Jon Hunter
Hi Brian, On 08/09/17 21:50, Brian Norris wrote: > From: Shawn Nematbakhsh > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > one instance of these functions correct, but not the second, fall-back > case. We use the fall-back only when the first command returns an > IN

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

2017-09-11 Thread Benson Leung
Hi Brian, On Fri, Sep 08, 2017 at 01:50:11PM -0700, Brian Norris wrote: > From: Shawn Nematbakhsh > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > one instance of these functions correct, but not the second, fall-back > case. We use the fall-back only when the first