Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

Hi Tudor, Am 2020-10-01 13:46, schrieb tudor.amba...@microchip.com: Am 2020-10-01 09:07, schrieb tudor.amba...@microchip.com: diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index cc68ea84318e..fd1c36d70a13 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

On 10/1/20 10:38 AM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Tudor, Hi, Michael, > > Am 2020-10-01 09:07, schrieb tudor.amba...@microchip.com: > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

On 10/1/20 4:21 AM, Michael Walle wrote: > Am 2020-09-30 12:35, schrieb Vignesh Raghavendra: > [..] >>> Signed-off-by: Michael Walle >>> --- >>> changes since v2: >>>  - add Kconfig option to be able to retain legacy behaviour >>>  - rebased the patch due to the spi-nor rewrite >>>  - dropped t

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

Hi Tudor, Am 2020-10-01 09:07, schrieb tudor.amba...@microchip.com: diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index cc68ea84318e..fd1c36d70a13 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2916,20 +2916,38 @@ static int spi_nor_quad_enabl

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

On 10/1/20 1:38 AM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Tudor, Hi, Michael, > >>> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c >>> index cc68ea84318e..fd1c36d70a13 100644 >>> --- a/dr

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

Am 2020-09-30 12:35, schrieb Vignesh Raghavendra: [..] Signed-off-by: Michael Walle --- changes since v2: - add Kconfig option to be able to retain legacy behaviour - rebased the patch due to the spi-nor rewrite - dropped the Fixes: tag, it doens't make sense after the spi-nor rewrite - me

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

Hi Tudor, diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index cc68ea84318e..fd1c36d70a13 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2916,20 +2916,38 @@ static int spi_nor_quad_enable(struct spi_nor *nor) } /** - * spi_nor_unlock_all()

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

Hi, Michael, PLease accept my apologies for the long delay. I do agree with Vignesh's comments. Few others below. On 3/27/20 5:59 PM, Michael Walle wrote: [cut] > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index cc68ea84318e..fd1c36d70a13 100644 > --- a/drivers/mtd/

Re: [PATCH v3] mtd: spi-nor: keep lock bits if they are non-volatile

On 3/27/20 9:29 PM, Michael Walle wrote: > Traditionally, linux unlocks the whole flash because there are legacy > devices which has the write protections bits set by default at startup. > If you actually want to use the flash protection bits, eg. because there > is a read-only part for a bootlo