Re: [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code

2015-10-09 Thread Vineet Gupta
On Friday 09 October 2015 07:04 PM, Kirill A. Shutemov wrote: On Fri, Oct 09, 2015 at 06:34:10PM +0530, Vineet Gupta wrote: > On Friday 09 October 2015 05:13 PM, Vineet Gupta wrote: > > - pgtable-generic.c: Fold individual #ifdef for each helper into a top > > level #ifdef. Makes code more r

Re: [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code

2015-10-09 Thread Kirill A. Shutemov
On Fri, Oct 09, 2015 at 06:34:10PM +0530, Vineet Gupta wrote: > On Friday 09 October 2015 05:13 PM, Vineet Gupta wrote: > > - pgtable-generic.c: Fold individual #ifdef for each helper into a top > > level #ifdef. Makes code more readable > > > > - Converted the stub helpers for !THP to BUILD_BUG

Re: [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code

2015-10-09 Thread Vineet Gupta
On Friday 09 October 2015 05:13 PM, Vineet Gupta wrote: > - pgtable-generic.c: Fold individual #ifdef for each helper into a top > level #ifdef. Makes code more readable > > - Converted the stub helpers for !THP to BUILD_BUG() vs. runtime BUG() > > Signed-off-by: Vineet Gupta Sorry for soundi