Re: [PATCH v3] kernel: add panic_on_taint

2020-05-11 Thread Luis Chamberlain
On Mon, May 11, 2020 at 04:03:25PM -0400, Rafael Aquini wrote: > On Mon, May 11, 2020 at 06:24:55PM +, Luis Chamberlain wrote: > > On Sat, May 09, 2020 at 09:57:37AM -0400, Rafael Aquini wrote: > > > +Trigger Kdump on add_taint() > > > + > > > + > > > +The kernel par

Re: [PATCH v3] kernel: add panic_on_taint

2020-05-11 Thread Rafael Aquini
On Mon, May 11, 2020 at 06:24:55PM +, Luis Chamberlain wrote: > On Sat, May 09, 2020 at 09:57:37AM -0400, Rafael Aquini wrote: > > +Trigger Kdump on add_taint() > > + > > + > > +The kernel parameter, panic_on_taint, calls panic() from within > > add_taint(), > > +wh

Re: [PATCH v3] kernel: add panic_on_taint

2020-05-11 Thread Luis Chamberlain
On Sat, May 09, 2020 at 09:57:37AM -0400, Rafael Aquini wrote: > +Trigger Kdump on add_taint() > + > + > +The kernel parameter, panic_on_taint, calls panic() from within add_taint(), > +whenever the value set in this bitmask matches with the bit flag being set > +by add_

Re: [PATCH v3] kernel: add panic_on_taint

2020-05-10 Thread Baoquan He
On 05/10/20 at 02:22pm, Rafael Aquini wrote: > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt > > > b/Documentation/admin-guide/kernel-parameters.txt > > > index 7bc83f3d9bdf..4a69fe49a70d 100644 > > > --- a/Documentation/admin-guide/kernel-parameters.txt > > > +++ b/Documentatio

Re: [PATCH v3] kernel: add panic_on_taint

2020-05-10 Thread Rafael Aquini
On Sun, May 10, 2020 at 10:59:21AM +0800, Baoquan He wrote: > On 05/09/20 at 09:57am, Rafael Aquini wrote: > > Analogously to the introduction of panic_on_warn, this patch > > introduces a kernel option named panic_on_taint in order to > > provide a simple and generic way to stop execution and catc

Re: [PATCH v3] kernel: add panic_on_taint

2020-05-09 Thread Baoquan He
On 05/09/20 at 09:10pm, Randy Dunlap wrote: > On 5/9/20 7:59 PM, Baoquan He wrote: > > Read admin-guide/tainted-kernels.rst, but still do not get what 'G' means. > > I interpret 'G' as GPL (strictly it means that no proprietary module has > been loaded). But I don't see why TAINT_PROPRIETARY_MODU

Re: [PATCH v3] kernel: add panic_on_taint

2020-05-09 Thread Randy Dunlap
On 5/9/20 7:59 PM, Baoquan He wrote: > Read admin-guide/tainted-kernels.rst, but still do not get what 'G' means. I interpret 'G' as GPL (strictly it means that no proprietary module has been loaded). But I don't see why TAINT_PROPRIETARY_MODULE is the only taint flag that has a non-blank c_false

Re: [PATCH v3] kernel: add panic_on_taint

2020-05-09 Thread Baoquan He
On 05/09/20 at 09:57am, Rafael Aquini wrote: > Analogously to the introduction of panic_on_warn, this patch > introduces a kernel option named panic_on_taint in order to > provide a simple and generic way to stop execution and catch > a coredump when the kernel gets tainted by any given taint flag.

Re: [PATCH v3] kernel: add panic_on_taint

2020-05-09 Thread Kees Cook
On Sat, May 09, 2020 at 09:57:37AM -0400, Rafael Aquini wrote: > Analogously to the introduction of panic_on_warn, this patch > introduces a kernel option named panic_on_taint in order to > provide a simple and generic way to stop execution and catch > a coredump when the kernel gets tainted by any