Re: [PATCH v3] f2fs: fix out-of-free problem caused by atomic write

2017-11-06 Thread Yunlong Song
I test it in an old kernel and find it hangs in gc process, maybe it is a bug of old kernel. On 2017/11/7 10:49, Jaegeuk Kim wrote: On 11/07, Yunlong Song wrote: This patch tries its best to collect prefree segments and make it free to be used in the commit process, or it will use up free segm

Re: [PATCH v3] f2fs: fix out-of-free problem caused by atomic write

2017-11-06 Thread Jaegeuk Kim
On 11/07, Yunlong Song wrote: > This patch tries its best to collect prefree segments and make it free to be > used > in the commit process, or it will use up free segments since prefree > segments > can not be used during commit process. > > As for your suggestion, I do consider that in an initia

Re: [PATCH v3] f2fs: fix out-of-free problem caused by atomic write

2017-11-06 Thread Chao Yu
On 2017/11/7 10:24, Jaegeuk Kim wrote: > On 11/07, Chao Yu wrote: >> On 2017/11/7 9:55, Jaegeuk Kim wrote: >>> On 11/06, Yunlong Song wrote: f2fs_balance_fs only actives once in the commit_inmem_pages, but there are more than one page to commit, so all the other pages will miss the c

Re: [PATCH v3] f2fs: fix out-of-free problem caused by atomic write

2017-11-06 Thread Yunlong Song
This patch tries its best to collect prefree segments and make it free to be used in the commit process, or it will use up free segments since prefree segments can not be used during commit process. As for your suggestion, I do consider that in an initial patch which does not send out, but I a

Re: [PATCH v3] f2fs: fix out-of-free problem caused by atomic write

2017-11-06 Thread Jaegeuk Kim
On 11/07, Chao Yu wrote: > On 2017/11/7 9:55, Jaegeuk Kim wrote: > > On 11/06, Yunlong Song wrote: > >> f2fs_balance_fs only actives once in the commit_inmem_pages, but there > >> are more than one page to commit, so all the other pages will miss the > >> check. This will lead to out-of-free proble

Re: [PATCH v3] f2fs: fix out-of-free problem caused by atomic write

2017-11-06 Thread Chao Yu
On 2017/11/7 9:55, Jaegeuk Kim wrote: > On 11/06, Yunlong Song wrote: >> f2fs_balance_fs only actives once in the commit_inmem_pages, but there >> are more than one page to commit, so all the other pages will miss the >> check. This will lead to out-of-free problem when commit a very large >> file.

Re: [PATCH v3] f2fs: fix out-of-free problem caused by atomic write

2017-11-06 Thread Jaegeuk Kim
On 11/06, Yunlong Song wrote: > f2fs_balance_fs only actives once in the commit_inmem_pages, but there > are more than one page to commit, so all the other pages will miss the > check. This will lead to out-of-free problem when commit a very large > file. However, we cannot do f2fs_balance_fs for e