Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-12 Thread Michal Simek
Hi Randy, On 02. 09. 19 18:52, Linus Torvalds wrote: > On Mon, Sep 2, 2019 at 6:17 AM Michal Simek wrote: >> >> Randy/Linus: Are you going create regular patch from this? > > Since I can't even test it, and Randy did most of the work (and that > last patch worked for him too), I'd suggest he jus

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-02 Thread Linus Torvalds
On Mon, Sep 2, 2019 at 6:17 AM Michal Simek wrote: > > Randy/Linus: Are you going create regular patch from this? Since I can't even test it, and Randy did most of the work (and that last patch worked for him too), I'd suggest he just send it in as his. You can add my acked-by or sign-of dependi

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-02 Thread Randy Dunlap
On 9/1/19 9:58 PM, Linus Torvalds wrote: > On Sun, Sep 1, 2019 at 7:10 PM Randy Dunlap wrote: >> >> I guess we need a way to coerce that to call get_user_1(), >> such as a typecast. This _seems_ to work (i.e., call get_user_1()): > > No, I oversimplified. > > Try this slightly modified patch in

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-02 Thread Michal Simek
On 02. 09. 19 6:58, Linus Torvalds wrote: > On Sun, Sep 1, 2019 at 7:10 PM Randy Dunlap wrote: >> >> I guess we need a way to coerce that to call get_user_1(), >> such as a typecast. This _seems_ to work (i.e., call get_user_1()): > > No, I oversimplified. > > Try this slightly modified patch i

RE: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-02 Thread David Laight
From: Randy Dunlap > Sent: 01 September 2019 15:56 > arch/microblaze/ is missing support for get_user() of size 8 bytes, > so add it by using __copy_from_user(). Ugg Use get_user() for 4 bytes twice and combine the returned values. David - Registered Address Lakeside, Bramley Road,

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-01 Thread Linus Torvalds
On Sun, Sep 1, 2019 at 7:10 PM Randy Dunlap wrote: > > I guess we need a way to coerce that to call get_user_1(), > such as a typecast. This _seems_ to work (i.e., call get_user_1()): No, I oversimplified. Try this slightly modified patch instead. Linus arch/microblaze/includ

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-01 Thread Randy Dunlap
On 9/1/19 12:10 PM, Randy Dunlap wrote: > On 9/1/19 10:31 AM, Linus Torvalds wrote: >> On Sun, Sep 1, 2019 at 10:07 AM Linus Torvalds >> wrote: >>> >>> I guess I'll apply it. I'm not sure why you _care_ about microblaze, but ... > > It was just a response to the 0day build bot reporting build err

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-01 Thread Randy Dunlap
On 9/1/19 10:33 AM, Michal Simek wrote: > Hi, > > On 01. 09. 19 19:07, Linus Torvalds wrote: >> On Sun, Sep 1, 2019 at 7:55 AM Randy Dunlap wrote: >>> >>> What is a reasonable path for having this patch merged? >>> I have sent several emails to Micahl Simek but he seems to have >>> dropped active

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-01 Thread Randy Dunlap
On 9/1/19 10:31 AM, Linus Torvalds wrote: > On Sun, Sep 1, 2019 at 10:07 AM Linus Torvalds > wrote: >> >> I guess I'll apply it. I'm not sure why you _care_ about microblaze, but ... It was just a response to the 0day build bot reporting build errors. > Ugh. As I was going to apply it, my code

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-01 Thread Michal Simek
Hi, On 01. 09. 19 19:07, Linus Torvalds wrote: > On Sun, Sep 1, 2019 at 7:55 AM Randy Dunlap wrote: >> >> What is a reasonable path for having this patch merged? >> I have sent several emails to Micahl Simek but he seems to have >> dropped active maintenance of arch/microblaze/. > > Yeah, I have

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-01 Thread Linus Torvalds
On Sun, Sep 1, 2019 at 10:07 AM Linus Torvalds wrote: > > I guess I'll apply it. I'm not sure why you _care_ about microblaze, but ... Ugh. As I was going to apply it, my code cleanliness conscience struck. I can't deal with that unnecessary duplication of code. Does something like the attached

Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes

2019-09-01 Thread Linus Torvalds
On Sun, Sep 1, 2019 at 7:55 AM Randy Dunlap wrote: > > What is a reasonable path for having this patch merged? > I have sent several emails to Micahl Simek but he seems to have > dropped active maintenance of arch/microblaze/. Yeah, I haven't gotten a pull request from him since March, and that w