Re: [PATCH v23 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2018-01-24 Thread Michael S. Tsirkin
On Wed, Jan 24, 2018 at 01:47:47PM +0800, Wei Wang wrote: > On 01/24/2018 01:01 PM, Michael S. Tsirkin wrote: > > On Wed, Jan 24, 2018 at 10:50:27AM +0800, Wei Wang wrote: > > This will not DTRT in all cases. It's quite possible > > that host does not need the kick when ring is half full but > > do

Re: [PATCH v23 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2018-01-23 Thread Wei Wang
On 01/24/2018 01:01 PM, Michael S. Tsirkin wrote: On Wed, Jan 24, 2018 at 10:50:27AM +0800, Wei Wang wrote: This will not DTRT in all cases. It's quite possible that host does not need the kick when ring is half full but does need it later when ring is full. You can kick at ring half full as opti

Re: [PATCH v23 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2018-01-23 Thread Michael S. Tsirkin
On Wed, Jan 24, 2018 at 10:50:27AM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free pages by sending a new cmd > id to the guest vi