Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-07 Thread Sean Christopherson
On Mon, Oct 07, 2019 at 03:04:12PM +0300, Jarkko Sakkinen wrote: > On Mon, Oct 07, 2019 at 11:10:24AM +0300, Jarkko Sakkinen wrote: > > Actually, maybe like this: > > > > struct sgx_enclave_add_page_desc { > > __u64 addr; > > __u64 offset; > > __u64 secinfo; > > __u16 mrmas

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-07 Thread Jarkko Sakkinen
On Mon, Oct 07, 2019 at 11:10:24AM +0300, Jarkko Sakkinen wrote: > Actually, maybe like this: > > struct sgx_enclave_add_page_desc { > __u64 addr; > __u64 offset; > __u64 secinfo; > __u16 mrmask; > __u8reserved[6]; > }; > > struct sgx_enclave_add_page { >

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-07 Thread Jarkko Sakkinen
On Mon, Oct 07, 2019 at 10:57:12AM +0300, Jarkko Sakkinen wrote: > On Sat, Oct 05, 2019 at 08:54:13AM -0700, Sean Christopherson wrote: > > On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > > > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > > > I'll tackle

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-07 Thread Jarkko Sakkinen
On Sat, Oct 05, 2019 at 11:39:39AM -0700, Sean Christopherson wrote: > On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > > I'll tackle this tomorrow. I've been working on the feature control MSR > > > serie

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-07 Thread Jarkko Sakkinen
On Sat, Oct 05, 2019 at 08:54:13AM -0700, Sean Christopherson wrote: > On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > > I'll tackle this tomorrow. I've been working on the feature control MSR > > > serie

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-06 Thread Jarkko Sakkinen
On Mon, Oct 07, 2019 at 02:38:17AM +0300, Jarkko Sakkinen wrote: > On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > > I'll tackle this tomorrow. I've been working on the feature control MSR > > > series an

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-06 Thread Jarkko Sakkinen
On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > I'll tackle this tomorrow. I've been working on the feature control MSR > > series and will get that sent out tomorrow as well. I should also be able > > to

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-05 Thread Sean Christopherson
On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > I'll tackle this tomorrow. I've been working on the feature control MSR > > series and will get that sent out tomorrow as well. I should also be able > > to

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-05 Thread Sean Christopherson
On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > > I'll tackle this tomorrow. I've been working on the feature control MSR > > series and will get that sent out tomorrow as well. I should also be able > > to

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-04 Thread Jarkko Sakkinen
On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote: > I'll tackle this tomorrow. I've been working on the feature control MSR > series and will get that sent out tomorrow as well. I should also be able > to get you the multi-page EADD patch. Great I'll compose the patch set duri

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-04 Thread Jarkko Sakkinen
On Thu, Oct 03, 2019 at 05:03:48PM -0700, Sean Christopherson wrote: > On Thu, Oct 03, 2019 at 02:18:04AM +0300, Jarkko Sakkinen wrote: > > Also there is two space bars after *every* sentence. Your text editor is > > totally broken somehow. > > I completely misunderstood your earlier comment, I th

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-03 Thread Sean Christopherson
I'll tackle this tomorrow. I've been working on the feature control MSR series and will get that sent out tomorrow as well. I should also be able to get you the multi-page EADD patch.

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-03 Thread Sean Christopherson
On Thu, Oct 03, 2019 at 02:18:04AM +0300, Jarkko Sakkinen wrote: > Also there is two space bars after *every* sentence. Your text editor is > totally broken somehow. I completely misunderstood your earlier comment, I thought you were saying there were random spaces at the end of lines. It's not m

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-02 Thread Jarkko Sakkinen
On Thu, Oct 03, 2019 at 02:18:04AM +0300, Jarkko Sakkinen wrote: > It would be even better to delete it completely than have it in the > current form. I would suggest that you do that and concentrate writing > steps 1-4 that I described above. To compensate my rather harsh (but correct) comments o

Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

2019-10-02 Thread Jarkko Sakkinen
On Tue, Sep 03, 2019 at 05:26:47PM +0300, Jarkko Sakkinen wrote: > From: Sean Christopherson > > The basic concept and implementation is very similar to the kernel's > exception fixup mechanism. The key differences are that the kernel > handler is hardcoded and the fixup entry addresses are rela