Re: [PATCH v2 5/5] clk: mediatek: Add MT8192 clock support

2020-08-11 Thread Weiyi Lu
On Wed, 2020-07-29 at 11:32 +0200, Enric Balletbo Serra wrote: > Hi Weiyi, > > Thank you for your patch. Some few comment below, I'll focus on > clk-mt8192-mm file, but I think can apply to other files too. > > [snip] > > > diff --git a/drivers/clk/mediatek/clk-mt8192-mm.c > > b/drivers/clk/med

Re: [PATCH v2 5/5] clk: mediatek: Add MT8192 clock support

2020-07-29 Thread Enric Balletbo Serra
Hi Weiyi, Thank you for your patch. Some few comment below, I'll focus on clk-mt8192-mm file, but I think can apply to other files too. [snip] > diff --git a/drivers/clk/mediatek/clk-mt8192-mm.c > b/drivers/clk/mediatek/clk-mt8192-mm.c > new file mode 100644 > index 000..02eef24 > --- /dev/