Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Gang He
>>> > On 11/03/2015 04:47 PM, Gang He wrote: >> >> >> > >>> On 11/03/2015 04:15 PM, Gang He wrote: Hello Junxiao, See my comments inline. >>> > Hi Gang, > > This is not like a right patch. > First, online file check only checks inode's block n

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Junxiao Bi
On 11/03/2015 04:47 PM, Gang He wrote: > > > >> On 11/03/2015 04:15 PM, Gang He wrote: >>> Hello Junxiao, >>> >>> See my comments inline. >>> >>> >> Hi Gang, This is not like a right patch. First, online file check only checks inode's block number, valid flag, f

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Gang He
>>> > On 11/03/2015 04:15 PM, Gang He wrote: >> Hello Junxiao, >> >> See my comments inline. >> >> > >>> Hi Gang, >>> >>> This is not like a right patch. >>> First, online file check only checks inode's block number, valid flag, >>> fs generation value, and meta ecc. I never see a real c

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Junxiao Bi
On 11/03/2015 04:15 PM, Gang He wrote: > Hello Junxiao, > > See my comments inline. > > >> Hi Gang, >> >> This is not like a right patch. >> First, online file check only checks inode's block number, valid flag, >> fs generation value, and meta ecc. I never see a real corruption >> happened

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Gang He
Hello Junxiao, See my comments inline. >>> > Hi Gang, > > This is not like a right patch. > First, online file check only checks inode's block number, valid flag, > fs generation value, and meta ecc. I never see a real corruption > happened only on this field, if these fields are corrupted, th

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-02 Thread Junxiao Bi
Hi Gang, This is not like a right patch. First, online file check only checks inode's block number, valid flag, fs generation value, and meta ecc. I never see a real corruption happened only on this field, if these fields are corrupted, that means something bad may happen on other place. So fix th