Re: [PATCH v2 4/4] net: ethoc: implement ethtool operations

2014-01-30 Thread Ben Hutchings
On Thu, 2014-01-30 at 07:04 +0400, Max Filippov wrote: > On Thu, Jan 30, 2014 at 5:59 AM, Ben Hutchings wrote: > > On Wed, 2014-01-29 at 10:00 +0400, Max Filippov wrote: [...] > >> + priv->num_tx = rounddown_pow_of_two(ring->tx_pending); > > > > Range check? > > May there be requested more th

Re: [PATCH v2 4/4] net: ethoc: implement ethtool operations

2014-01-29 Thread Max Filippov
On Thu, Jan 30, 2014 at 5:59 AM, Ben Hutchings wrote: > On Wed, 2014-01-29 at 10:00 +0400, Max Filippov wrote: >> The following methods are implemented: >> - get/set settings; >> - get registers length/registers; >> - get link state (standard implementation); >> - get/set ring parameters; >> - get

Re: [PATCH v2 4/4] net: ethoc: implement ethtool operations

2014-01-29 Thread Ben Hutchings
On Wed, 2014-01-29 at 10:00 +0400, Max Filippov wrote: > The following methods are implemented: > - get/set settings; > - get registers length/registers; > - get link state (standard implementation); > - get/set ring parameters; > - get timestamping info (standard implementation). [...] > --- a/dri

Re: [PATCH v2 4/4] net: ethoc: implement ethtool operations

2014-01-28 Thread Florian Fainelli
Le 28/01/2014 22:00, Max Filippov a écrit : The following methods are implemented: - get/set settings; - get registers length/registers; - get link state (standard implementation); - get/set ring parameters; - get timestamping info (standard implementation). Ideally you should have one patch pe