Re: [PATCH v2 3/5] spi: spi-mtk-nor: use dma_alloc_coherent() for bounce buffer

2020-09-20 Thread Ikjoon Jang
On Fri, Sep 18, 2020 at 9:25 PM Chuanhong Guo wrote: > > Hi! > > On Fri, Sep 18, 2020 at 4:35 PM Ikjoon Jang wrote: > > > > Use dma_alloc_coherent() for bounce buffer instead of kmalloc. > > The commit message should explain why such a change is > needed. (i.e. why using dma_alloc_coherent here i

Re: [PATCH v2 3/5] spi: spi-mtk-nor: use dma_alloc_coherent() for bounce buffer

2020-09-18 Thread Chuanhong Guo
Hi! On Fri, Sep 18, 2020 at 4:35 PM Ikjoon Jang wrote: > > Use dma_alloc_coherent() for bounce buffer instead of kmalloc. The commit message should explain why such a change is needed. (i.e. why using dma_alloc_coherent here is better than kmalloc.) And if there's no benefit for this change I'd