RE: [PATCH v2 3/3] mmc: core: Add discard support to sd

2019-02-25 Thread Avri Altman
Ulf hi, Thanks a lot for your comments. > > On Wed, 6 Feb 2019 at 12:29, Avri Altman wrote: > > > > SD spec v5.1 adds discard support. The flows and commands are similar to > > mmc, so just set the discard arg in CMD38. > > So this means that we from now on, if the SD card supports discard, we

Re: [PATCH v2 3/3] mmc: core: Add discard support to sd

2019-02-25 Thread Ulf Hansson
On Wed, 6 Feb 2019 at 12:29, Avri Altman wrote: > > SD spec v5.1 adds discard support. The flows and commands are similar to > mmc, so just set the discard arg in CMD38. So this means that we from now on, if the SD card supports discard, we are going to use it in favor of erase. This is consisten

RE: [PATCH v2 3/3] mmc: core: Add discard support to sd

2019-02-23 Thread Avri Altman
> > > > On Wed, 6 Feb 2019 at 12:29, Avri Altman wrote: > > > > > > SD spec v5.1 adds discard support. The flows and commands are similar > to > > > mmc, so just set the discard arg in CMD38. > > > > > > Actually, there is no need to check for the spec version like we are > > > doing, as it is ass

RE: [PATCH v2 3/3] mmc: core: Add discard support to sd

2019-02-14 Thread Avri Altman
> > On Wed, 6 Feb 2019 at 12:29, Avri Altman wrote: > > > > SD spec v5.1 adds discard support. The flows and commands are similar to > > mmc, so just set the discard arg in CMD38. > > > > Actually, there is no need to check for the spec version like we are > > doing, as it is assured that the res

Re: [PATCH v2 3/3] mmc: core: Add discard support to sd

2019-02-06 Thread Ulf Hansson
On Wed, 6 Feb 2019 at 12:29, Avri Altman wrote: > > SD spec v5.1 adds discard support. The flows and commands are similar to > mmc, so just set the discard arg in CMD38. > > Actually, there is no need to check for the spec version like we are > doing, as it is assured that the reserved bits in ear