Re: [PATCH v2 3/3] f2fs: Handle casefolding with Encryption

2020-11-17 Thread Eric Biggers
On Tue, Nov 17, 2020 at 10:22:28PM -0800, Daniel Rosenberg wrote: > > > @@ -273,10 +308,14 @@ struct f2fs_dir_entry > > > *f2fs_find_target_dentry(const struct f2fs_dentry_ptr *d, > > > continue; > > > } > > > > > > - if (de->hash_code == fname->hash

Re: [PATCH v2 3/3] f2fs: Handle casefolding with Encryption

2020-11-17 Thread Daniel Rosenberg
On Tue, Nov 17, 2020 at 10:50 AM Eric Biggers wrote: > > > What is the assignment to dentry_page supposed to be accomplishing? It looks > like it's meant to pass up errors from f2fs_find_target_dentry(), but it > doesn't > do that. Woops. Fixed that for the next version. > > > @@ -222,14 +250,

Re: [PATCH v2 3/3] f2fs: Handle casefolding with Encryption

2020-11-17 Thread Eric Biggers
On Tue, Nov 17, 2020 at 04:03:15AM +, Daniel Rosenberg wrote: > Expand f2fs's casefolding support to include encrypted directories. To > index casefolded+encrypted directories, we use the SipHash of the > casefolded name, keyed by a key derived from the directory's fscrypt > master key. This