Re: [PATCH v2 3/3] drivers: android: binder: Remove excessive indentation

2013-03-12 Thread mirsal
On Mon, 2013-03-11 at 17:04 -0700, Joe Perches wrote: > On Tue, 2013-03-12 at 00:26 +0100, Mirsal Ennaime wrote: > > Remove one level of indentation from the binder proc page release code > > by using slightly different control semantics. > > > > This is a cosmetic patch which removes checkpatch "

Re: [PATCH v2 3/3] drivers: android: binder: Remove excessive indentation

2013-03-11 Thread Joe Perches
On Mon, 2013-03-11 at 17:21 -0700, Arve Hjønnevåg wrote: > On Mon, Mar 11, 2013 at 5:04 PM, Joe Perches wrote: > ... > > I think it's odd to use pr_info in binder_debug. > > Why not use KERN_DEBUG or pr_debug/dynamic_debugging? > > > > #define binder_debug(mask, x...) \ > > do { \ > >

Re: [PATCH v2 3/3] drivers: android: binder: Remove excessive indentation

2013-03-11 Thread Arve Hjønnevåg
On Mon, Mar 11, 2013 at 5:04 PM, Joe Perches wrote: ... > I think it's odd to use pr_info in binder_debug. > Why not use KERN_DEBUG or pr_debug/dynamic_debugging? > > #define binder_debug(mask, x...) \ > do { \ > if (binder_debug_mask & mask) \ > pr_

Re: [PATCH v2 3/3] drivers: android: binder: Remove excessive indentation

2013-03-11 Thread Joe Perches
On Tue, 2013-03-12 at 00:26 +0100, Mirsal Ennaime wrote: > Remove one level of indentation from the binder proc page release code > by using slightly different control semantics. > > This is a cosmetic patch which removes checkpatch "80-columns" warnings More trivia: > diff --git a/drivers/stagi