Re: [PATCH v2 27/28] ext4: xattr inode deduplication

2017-06-02 Thread Darrick J. Wong
On Fri, Jun 02, 2017 at 05:46:22AM -0700, Tahsin Erdogan wrote: > > Hmm... normally we'd supply sbi->s_csum_seed as the second argument so > > that the metadata checksum value also has the fs uuid stamped into it. > > I have thought about using sbi->s_csum_seed and was a little hesitant > because

Re: [PATCH v2 27/28] ext4: xattr inode deduplication

2017-06-02 Thread Tahsin Erdogan
> Hmm... normally we'd supply sbi->s_csum_seed as the second argument so > that the metadata checksum value also has the fs uuid stamped into it. I have thought about using sbi->s_csum_seed and was a little hesitant because it involves adding more complexity to e2fsprogs to handle cases like chang

Re: [PATCH v2 27/28] ext4: xattr inode deduplication

2017-06-01 Thread Darrick J. Wong
On Wed, May 31, 2017 at 03:33:57PM -0700, Tahsin Erdogan wrote: > Ext4 now supports xattr values that are up to 64k in size (vfs limit). > Large xattr values are stored in external inodes each one holding a > single value. Once written the data blocks of these inodes are immutable. > > The real wo