Re: [PATCH v2 22/40] tile: fix put_user sparse errors

On 1/13/2015 4:35 AM, Michael S. Tsirkin wrote: I wonder why didn't kbuild notify me about new warnings. Doesn't it build tile? Kbuild builds tilegx, which is an LP64 kernel. These issues are with the older platform, tilepro, which is an ILP32 kernel. There's certainly no reason we couldn't b

Re: [PATCH v2 22/40] tile: fix put_user sparse errors

On Mon, Jan 12, 2015 at 04:56:54PM -0500, Chris Metcalf wrote: > Nack for this patch as-is. Thanks, I dropped it and the next one from my tree, looks like you are on track to fixing it all in the tile tree. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH v2 22/40] tile: fix put_user sparse errors

On Tue, Jan 13, 2015 at 11:35:35AM +0200, Michael S. Tsirkin wrote: > On Mon, Jan 12, 2015 at 04:56:54PM -0500, Chris Metcalf wrote: > > Nack for this patch as-is. > > > > On 1/6/2015 10:44 AM, Michael S. Tsirkin wrote: > > >virtio wants to write bitwise types to userspace using put_user. > > >At

Re: [PATCH v2 22/40] tile: fix put_user sparse errors

On Mon, Jan 12, 2015 at 04:56:54PM -0500, Chris Metcalf wrote: > Nack for this patch as-is. > > On 1/6/2015 10:44 AM, Michael S. Tsirkin wrote: > >virtio wants to write bitwise types to userspace using put_user. > >At the moment this triggers sparse errors, since the value is passed > >through an

Re: [PATCH v2 22/40] tile: fix put_user sparse errors

Nack for this patch as-is. On 1/6/2015 10:44 AM, Michael S. Tsirkin wrote: virtio wants to write bitwise types to userspace using put_user. At the moment this triggers sparse errors, since the value is passed through an integer. For example: __le32 __user *p; __le32 x;