Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

2020-11-18 Thread Stephen Boyd
Quoting Manivannan Sadhasivam (2020-11-18 06:44:01) > On Sat, Nov 14, 2020 at 12:35:27PM -0800, Stephen Boyd wrote: > > Quoting Vinod Koul (2020-11-06 01:38:19) > > > On 05-11-20, 16:18, Manivannan Sadhasivam wrote: > > > > +#include "reset.h" > > > > + > > > > +enum { > > > > + P_BI_TCXO, > >

Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

2020-11-18 Thread Manivannan Sadhasivam
On Sat, Nov 14, 2020 at 12:35:27PM -0800, Stephen Boyd wrote: > Quoting Vinod Koul (2020-11-06 01:38:19) > > On 05-11-20, 16:18, Manivannan Sadhasivam wrote: > > > +#include "reset.h" > > > + > > > +enum { > > > + P_BI_TCXO, > > > + P_CORE_BI_PLL_TEST_SE, > > > > This is for test and we re

Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

2020-11-15 Thread Vinod Koul
On 14-11-20, 19:17, Bjorn Andersson wrote: > > > +enum { > > > + P_BI_TCXO, > > > + P_CORE_BI_PLL_TEST_SE, > > > > This is for test and we removed this for upstream, so can you do that as > > well (not parent will decrease for clks below) > > > > We have several other platforms that includes th

Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

2020-11-14 Thread Bjorn Andersson
On Fri 06 Nov 03:38 CST 2020, Vinod Koul wrote: > On 05-11-20, 16:18, Manivannan Sadhasivam wrote: > > From: Naveen Yadav > > > > Add Global Clock Controller (GCC) support for SDX55 SoCs from Qualcomm. > > > > Signed-off-by: Naveen Yadav > > [mani: converted to parent_data, commented critical

Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

2020-11-14 Thread Stephen Boyd
Quoting Vinod Koul (2020-11-06 01:38:19) > On 05-11-20, 16:18, Manivannan Sadhasivam wrote: > > +#include "reset.h" > > + > > +enum { > > + P_BI_TCXO, > > + P_CORE_BI_PLL_TEST_SE, > > This is for test and we removed this for upstream, so can you do that as > well (not parent will decrease

Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

2020-11-06 Thread Vinod Koul
On 05-11-20, 16:18, Manivannan Sadhasivam wrote: > From: Naveen Yadav > > Add Global Clock Controller (GCC) support for SDX55 SoCs from Qualcomm. > > Signed-off-by: Naveen Yadav > [mani: converted to parent_data, commented critical clocks, cleanups] > Signed-off-by: Manivannan Sadhasivam > ---