Re: [PATCH v2 2/3] video: xilinxfb: Do not use out_be32 IO function

2013-05-31 Thread Michal Simek
On 05/31/2013 12:04 AM, Arnd Bergmann wrote: > On Thursday 30 May 2013 11:41:01 Michal Simek wrote: >> * To perform the read/write on the registers we need to check on >> * which bus its connected and call the appropriate write API. >> */ >> -static void xilinx_fb_out_be32(struct xilinxfb_drv

Re: [PATCH v2 2/3] video: xilinxfb: Do not use out_be32 IO function

2013-05-30 Thread Timur Tabi
On Thu, May 30, 2013 at 5:04 PM, Arnd Bergmann wrote: > > This is probably missing barriers, and is wrong on systems on which > the endianess of the device is different from the CPU. I suggest what was done in fsl_ssi.c: #ifdef PPC #define read_ssi(addr) in_be32(addr) #define write_

Re: [PATCH v2 2/3] video: xilinxfb: Do not use out_be32 IO function

2013-05-30 Thread Arnd Bergmann
On Thursday 30 May 2013 11:41:01 Michal Simek wrote: > * To perform the read/write on the registers we need to check on > * which bus its connected and call the appropriate write API. > */ > -static void xilinx_fb_out_be32(struct xilinxfb_drvdata *drvdata, u32 offset, > +static void xilinx_fb