Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-15 Thread Pavel Machek
Hi! > >> The driver uses a private lock for synchronization of the xmit function and > >> the xmit completion handler, but since the NETIF_F_LLTX flag is not set, > >> the xmit function is also called with the xmit_lock held. > >> > >> On the other hand the completion handler uses the reverse loc

Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-15 Thread Lino Sanfilippo
Hi, On 15.12.2016 10:45, Pavel Machek wrote: > Hi! > >> The driver uses a private lock for synchronization of the xmit function and >> the xmit completion handler, but since the NETIF_F_LLTX flag is not set, >> the xmit function is also called with the xmit_lock held. >> >> On the other hand the

Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-15 Thread Lino Sanfilippo
Hi, On 15.12.2016 19:52, Niklas Cassel wrote: > Since v1 of this patch has already been merged to net-next, I think that > you should create a new patch on top of that, rather than submitting a v2. > > http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/drivers/net/ethernet/stmi

Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-15 Thread Pavel Machek
On Thu 2016-12-15 11:08:36, Giuseppe CAVALLARO wrote: > On 12/15/2016 10:45 AM, Pavel Machek wrote: > >Giuseppe, is there documentation available for the chip? Driver says > > > > Documentation available at: > > http://www.stlinux.com > > > >but that page does not work for me... > > Hi P

Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-15 Thread Giuseppe CAVALLARO
On 12/15/2016 10:45 AM, Pavel Machek wrote: Giuseppe, is there documentation available for the chip? Driver says Documentation available at: http://www.stlinux.com but that page does not work for me... Hi Pavel, yes the page has been removed but all the relevant and updated driver

Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-15 Thread Pavel Machek
Hi! > The driver uses a private lock for synchronization of the xmit function and > the xmit completion handler, but since the NETIF_F_LLTX flag is not set, > the xmit function is also called with the xmit_lock held. > > On the other hand the completion handler uses the reverse locking order by >