Re: [PATCH v2 2/2] lockdep: Fix merging of hlocks with non-zero references

2019-05-27 Thread Imre Deak
On Mon, May 27, 2019 at 06:06:18PM +0200, Peter Zijlstra wrote: > On Mon, May 27, 2019 at 05:14:38PM +0200, Peter Zijlstra wrote: > > On Fri, May 24, 2019 at 11:15:09PM +0300, Imre Deak wrote: > > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > > > index 967352d32af1..9e2a4ab6c

Re: [PATCH v2 2/2] lockdep: Fix merging of hlocks with non-zero references

2019-05-27 Thread Peter Zijlstra
On Mon, May 27, 2019 at 06:44:29PM +0300, Imre Deak wrote: > On Mon, May 27, 2019 at 05:14:38PM +0200, Peter Zijlstra wrote: > > On Fri, May 24, 2019 at 11:15:09PM +0300, Imre Deak wrote: > > > - if (DEBUG_LOCKS_WARN_ON(hlock->references == > > > UINT_MAX)) > > > > What t

Re: [PATCH v2 2/2] lockdep: Fix merging of hlocks with non-zero references

2019-05-27 Thread Peter Zijlstra
On Mon, May 27, 2019 at 05:14:38PM +0200, Peter Zijlstra wrote: > On Fri, May 24, 2019 at 11:15:09PM +0300, Imre Deak wrote: > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > > index 967352d32af1..9e2a4ab6c731 100644 > > --- a/kernel/locking/lockdep.c > > +++ b/kernel/locking/l

Re: [PATCH v2 2/2] lockdep: Fix merging of hlocks with non-zero references

2019-05-27 Thread Imre Deak
On Mon, May 27, 2019 at 05:14:38PM +0200, Peter Zijlstra wrote: > On Fri, May 24, 2019 at 11:15:09PM +0300, Imre Deak wrote: > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > > index 967352d32af1..9e2a4ab6c731 100644 > > --- a/kernel/locking/lockdep.c > > +++ b/kernel/locking/l

Re: [PATCH v2 2/2] lockdep: Fix merging of hlocks with non-zero references

2019-05-27 Thread Peter Zijlstra
On Fri, May 24, 2019 at 11:15:09PM +0300, Imre Deak wrote: > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index 967352d32af1..9e2a4ab6c731 100644 > --- a/kernel/locking/lockdep.c > +++ b/kernel/locking/lockdep.c > @@ -3637,6 +3637,11 @@ print_lock_nested_lock_not_held(struct t