Re: [PATCH v2 2/2] input: soc_button_array for newer surface devices

2019-07-17 Thread Maximilian Luz
On 7/16/19 10:18 PM, Dmitry Torokhov wrote: OK, fair enough. By the way, I see you are adding some #ifdef CONFIG_ACPI and stubbing out new functions, but the driver does not really work without ACPI (acpi_match_device() will fail in this case I would think and that will cause probe() to abort). S

Re: [PATCH v2 2/2] input: soc_button_array for newer surface devices

2019-07-17 Thread Dmitry Torokhov
On Tue, Jul 16, 2019 at 08:19:04PM +0200, Maximilian Luz wrote: > > Hi, > > On 7/16/19 9:21 AM, Dmitry Torokhov wrote: > > When you are saying that Pro 4 and later models use different > > notifications, does this mean that Pro 4 does not define any GPIOs? > > Unfortunately, at least the Surface

Re: [PATCH v2 2/2] input: soc_button_array for newer surface devices

2019-07-16 Thread Maximilian Luz
Hi, On 7/16/19 9:21 AM, Dmitry Torokhov wrote: When you are saying that Pro 4 and later models use different notifications, does this mean that Pro 4 does not define any GPIOs? Unfortunately, at least the Surface Book (first generation, buttons are handled the same way as on the Pro 4) has G

Re: [PATCH v2 2/2] input: soc_button_array for newer surface devices

2019-07-16 Thread Dmitry Torokhov
Hi Maximilian, On Tue, Jul 02, 2019 at 02:37:40AM +0200, Maximilian Luz wrote: > Power and volume button support for 5th and 6th genration Microsoft > Surface devices via soc_button_array. > > Note that these devices use the same MSHW0040 device as on the Surface > Pro 4, however the implementati

Re: [PATCH v2 2/2] input: soc_button_array for newer surface devices

2019-07-04 Thread Maximilian Luz
On 7/2/19 2:37 AM, Maximilian Luz wrote: +static int soc_device_check_MSHW0040(struct device *dev) +{ + acpi_handle handle = ACPI_HANDLE(dev); + union acpi_object *result; + u64 oem_platform_rev = 0; + int gpios; + + // get OEM platform revision + result = acpi