Re: [PATCH v2 2/2] gpio: Add Realtek Otto GPIO support

2021-03-22 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 11:48 PM Sander Vanheule wrote: > On Fri, 2021-03-19 at 23:24 +0200, Andy Shevchenko wrote: > > On Fri, Mar 19, 2021 at 11:20 PM Sander Vanheule < > > san...@svanheule.net> wrote: > > > On Fri, 2021-03-19 at 19:57 +0200, Andy Shevchenko wrote: ... > > > The point I was tr

Re: [PATCH v2 2/2] gpio: Add Realtek Otto GPIO support

2021-03-19 Thread Sander Vanheule
On Fri, 2021-03-19 at 23:24 +0200, Andy Shevchenko wrote: > On Fri, Mar 19, 2021 at 11:20 PM Sander Vanheule < > san...@svanheule.net> wrote: > > On Fri, 2021-03-19 at 19:57 +0200, Andy Shevchenko wrote: > > > On Fri, Mar 19, 2021 at 5:51 PM Sander Vanheule > > > wrote: > > > > On Wed, 2021-03-17

Re: [PATCH v2 2/2] gpio: Add Realtek Otto GPIO support

2021-03-19 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 11:20 PM Sander Vanheule wrote: > On Fri, 2021-03-19 at 19:57 +0200, Andy Shevchenko wrote: > > On Fri, Mar 19, 2021 at 5:51 PM Sander Vanheule > > wrote: > > > On Wed, 2021-03-17 at 15:08 +0200, Andy Shevchenko wrote: > > > > On Mon, Mar 15, 2021 at 11:11 PM Sander Vanheu

Re: [PATCH v2 2/2] gpio: Add Realtek Otto GPIO support

2021-03-19 Thread Sander Vanheule
On Fri, 2021-03-19 at 19:57 +0200, Andy Shevchenko wrote: > On Fri, Mar 19, 2021 at 5:51 PM Sander Vanheule > wrote: > > On Wed, 2021-03-17 at 15:08 +0200, Andy Shevchenko wrote: > > > On Mon, Mar 15, 2021 at 11:11 PM Sander Vanheule < > > > san...@svanheule.net> wrote: > > ... > > > > > +#inclu

Re: [PATCH v2 2/2] gpio: Add Realtek Otto GPIO support

2021-03-19 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 5:51 PM Sander Vanheule wrote: > On Wed, 2021-03-17 at 15:08 +0200, Andy Shevchenko wrote: > > On Mon, Mar 15, 2021 at 11:11 PM Sander Vanheule < > > san...@svanheule.net> wrote: ... > > > +#include > > > > Not sure why you need this? See below. > > > + return swa

Re: [PATCH v2 2/2] gpio: Add Realtek Otto GPIO support

2021-03-19 Thread Sander Vanheule
Hi Andy, Thanks for the review. I'll address the style comments in a v3. Some further comments and discussion below. On Wed, 2021-03-17 at 15:08 +0200, Andy Shevchenko wrote: > On Mon, Mar 15, 2021 at 11:11 PM Sander Vanheule < > san...@svanheule.net> wrote: > > +   depends on OF_GPIO > >

Re: [PATCH v2 2/2] gpio: Add Realtek Otto GPIO support

2021-03-17 Thread Andy Shevchenko
On Mon, Mar 15, 2021 at 11:11 PM Sander Vanheule wrote: > > Realtek MIPS SoCs (platform name Otto) have GPIO controllers with up to > 64 GPIOs, divided over two banks. Each bank has a set of registers for > 32 GPIOs, with support for edge-triggered interrupts. > > Each GPIO bank consists of four 8