Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-25 Thread Tanwar, Rahul
On 25/6/2020 1:58 pm, Uwe Kleine-König wrote: > On Thu, Jun 25, 2020 at 12:23:54PM +0800, Tanwar, Rahul wrote: >> Hi Philipp, >> >> On 18/6/2020 8:25 pm, Philipp Zabel wrote: >>> Hi Rahul, >>> >>> On Thu, 2020-06-18 at 20:05 +0800, Rahul Tanwar wrote: Intel Lightning Mountain(LGM) SoC conta

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-25 Thread Tanwar, Rahul
Hi Uwe, Thanks for your valuable feedback. On 19/6/2020 2:02 pm, Uwe Kleine-König wrote: > Hello Rahul, > > On Thu, Jun 18, 2020 at 08:05:13PM +0800, Rahul Tanwar wrote: >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. >> This PWM controller does not have any other consumer,

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-24 Thread Uwe Kleine-König
On Thu, Jun 25, 2020 at 12:23:54PM +0800, Tanwar, Rahul wrote: > > Hi Philipp, > > On 18/6/2020 8:25 pm, Philipp Zabel wrote: > > Hi Rahul, > > > > On Thu, 2020-06-18 at 20:05 +0800, Rahul Tanwar wrote: > >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > >> This PWM controller

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-24 Thread Tanwar, Rahul
Hi Philipp, On 18/6/2020 8:25 pm, Philipp Zabel wrote: > Hi Rahul, > > On Thu, 2020-06-18 at 20:05 +0800, Rahul Tanwar wrote: >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. >> This PWM controller does not have any other consumer, it is a >> dedicated PWM controller for fan a

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-18 Thread Uwe Kleine-König
Hello again, On Fri, Jun 19, 2020 at 08:02:13AM +0200, Uwe Kleine-König wrote: > You had concerns about my review feedback that I don't like the fan > stuff in the PWM driver. I still think that the fan part doesn't belong > here. I suggest splitting the patch. First introduce a generic PWM drive

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-18 Thread Uwe Kleine-König
Hello Rahul, On Thu, Jun 18, 2020 at 08:05:13PM +0800, Rahul Tanwar wrote: > Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > This PWM controller does not have any other consumer, it is a > dedicated PWM controller for fan attached to the system. Add > driver for this PWM fan con

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-18 Thread Philipp Zabel
Hi Rahul, On Thu, 2020-06-18 at 20:05 +0800, Rahul Tanwar wrote: > Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > This PWM controller does not have any other consumer, it is a > dedicated PWM controller for fan attached to the system. Add > driver for this PWM fan controller. >