Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework

2021-02-21 Thread Hector Martin
On 21/02/2021 04.11, Krzysztof Kozlowski wrote: On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote: This should've gone in the next patch. A previous reviewer told me to put declarations at the top of the file, so I put it there and moved this one along with it, but I'll keep it to th

Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework

2021-02-20 Thread Krzysztof Kozlowski
On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote: > > Separate patch for trivial renaming. > > I think it makes sense to do this rename together with the first change > above, as it keeps both functions symmetric. Otherwise we end up with an > inconsistent function naming between both

Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework

2021-02-18 Thread Hector Martin
On 16/02/2021 03.40, Krzysztof Kozlowski wrote: On Mon, Feb 15, 2021 at 09:17:07PM +0900, Hector Martin wrote: * Split out s3c24xx_serial_tx_chars from s3c24xx_serial_tx_irq, where only the latter acquires the port lock. I miss here information why you do all this. Added an explanation fo

Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:07PM +0900, Hector Martin wrote: > * Split out s3c24xx_serial_tx_chars from s3c24xx_serial_tx_irq, > where only the latter acquires the port lock. I miss here information why you do all this. > > * For S3C64xx, return IRQ_NONE if no flag bits were set, so the >