Re: [PATCH v2 13/14] Move ad7746 out of staging

2018-04-15 Thread Jonathan Cameron
On Sun, 15 Apr 2018 11:46:09 -0700 Joe Perches wrote: > On Sun, 2018-04-15 at 18:04 +0100, Jonathan Cameron wrote: > > On Fri, 13 Apr 2018 13:36:50 -0300 > > Hernán Gonzalez wrote: > > > > > Signed-off-by: Hernán Gonzalez > > > > A few comments inline. > > And a trivial typo and other

Re: [PATCH v2 13/14] Move ad7746 out of staging

2018-04-15 Thread Joe Perches
On Sun, 2018-04-15 at 18:04 +0100, Jonathan Cameron wrote: > On Fri, 13 Apr 2018 13:36:50 -0300 > Hernán Gonzalez wrote: > > > Signed-off-by: Hernán Gonzalez > > A few comments inline. And a trivial typo and other bits > > diff --git a/drivers/iio/cdc/Makefile b/drivers/iio/cdc/Makefile [] >

Re: [PATCH v2 13/14] Move ad7746 out of staging

2018-04-15 Thread Jonathan Cameron
On Fri, 13 Apr 2018 13:36:50 -0300 Hernán Gonzalez wrote: > Signed-off-by: Hernán Gonzalez A few comments inline. Also nice to have a bit of a description of the driver in the patch moving it out of staging. It's a patch people might actually notice as to many people it is some new hardware su