Re: [PATCH v2 1/7] modules: Create rlimit for module space

2018-10-23 Thread Michal Hocko
On Fri 12-10-18 17:04:46, Edgecombe, Rick P wrote: [...] > Any thoughts on if instead of all this there was just a system wide limit on > BPF > JIT module space usage? We do allow to charge vmalloc memory to a memory cgroup. Isn't that a way forward? -- Michal Hocko SUSE Labs

Re: [PATCH v2 1/7] modules: Create rlimit for module space

2018-10-12 Thread Jann Horn
On Sat, Oct 13, 2018 at 2:04 AM Edgecombe, Rick P wrote: > On Fri, 2018-10-12 at 19:22 +0200, Jann Horn wrote: > > On Fri, Oct 12, 2018 at 7:04 PM Edgecombe, Rick P > > wrote: > > > On Fri, 2018-10-12 at 02:35 +0200, Jann Horn wrote: > > > > Why all the rbtree stuff instead of stashing a pointer

Re: [PATCH v2 1/7] modules: Create rlimit for module space

2018-10-12 Thread Edgecombe, Rick P
On Fri, 2018-10-12 at 19:22 +0200, Jann Horn wrote: > On Fri, Oct 12, 2018 at 7:04 PM Edgecombe, Rick P > wrote: > > On Fri, 2018-10-12 at 02:35 +0200, Jann Horn wrote: > > > Why all the rbtree stuff instead of stashing a pointer in struct > > > vmap_area, or something like that? > > > > Since th

Re: [PATCH v2 1/7] modules: Create rlimit for module space

2018-10-12 Thread Jann Horn
On Fri, Oct 12, 2018 at 2:35 AM Jann Horn wrote: > On Fri, Oct 12, 2018 at 1:40 AM Rick Edgecombe > wrote: > > This introduces a new rlimit, RLIMIT_MODSPACE, which limits the amount of > > module space a user can use. The intention is to be able to limit module > > space > > allocations that may

Re: [PATCH v2 1/7] modules: Create rlimit for module space

2018-10-12 Thread Jann Horn
On Fri, Oct 12, 2018 at 7:04 PM Edgecombe, Rick P wrote: > On Fri, 2018-10-12 at 02:35 +0200, Jann Horn wrote: > > On Fri, Oct 12, 2018 at 1:40 AM Rick Edgecombe > > wrote: > > > This introduces a new rlimit, RLIMIT_MODSPACE, which limits the amount of > > > module space a user can use. The inten

Re: [PATCH v2 1/7] modules: Create rlimit for module space

2018-10-12 Thread Edgecombe, Rick P
On Fri, 2018-10-12 at 02:35 +0200, Jann Horn wrote: > On Fri, Oct 12, 2018 at 1:40 AM Rick Edgecombe > wrote: > > This introduces a new rlimit, RLIMIT_MODSPACE, which limits the amount of > > module space a user can use. The intention is to be able to limit module > > space > > allocations that ma

Re: [PATCH v2 1/7] modules: Create rlimit for module space

2018-10-11 Thread Jann Horn
On Fri, Oct 12, 2018 at 1:40 AM Rick Edgecombe wrote: > This introduces a new rlimit, RLIMIT_MODSPACE, which limits the amount of > module space a user can use. The intention is to be able to limit module space > allocations that may come from un-privlidged users inserting e/BPF filters. Note tha