Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-30 Thread Roger Quadros
On 29/01/15 18:56, Tony Lindgren wrote: > * Roger Quadros [150129 03:34]: >> On 28/01/15 19:09, Tony Lindgren wrote: >>> * Roger Quadros [150128 04:15]: On 28/01/15 04:19, Chanwoo Choi wrote: >> >> I still fail to understand that we need to call disable_irq() in >> .suspend() an

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-29 Thread Tony Lindgren
* Roger Quadros [150129 03:34]: > On 28/01/15 19:09, Tony Lindgren wrote: > > * Roger Quadros [150128 04:15]: > >> On 28/01/15 04:19, Chanwoo Choi wrote: > > I still fail to understand that we need to call disable_irq() in > .suspend() and > enable_irq() in .resume() > >

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-29 Thread Roger Quadros
On 28/01/15 19:09, Tony Lindgren wrote: > * Roger Quadros [150128 04:15]: >> On 28/01/15 04:19, Chanwoo Choi wrote: I still fail to understand that we need to call disable_irq() in .suspend() and enable_irq() in .resume() can you point me to any other drivers doing s

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Tony Lindgren
* Roger Quadros [150128 04:15]: > On 28/01/15 04:19, Chanwoo Choi wrote: > >> > >> I still fail to understand that we need to call disable_irq() in > >> .suspend() and > >> enable_irq() in .resume() > >> > >> can you point me to any other drivers doing so? > > > > You can refer the suspend funct

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Roger Quadros
Chanwoo, On 28/01/15 04:19, Chanwoo Choi wrote: > Hi Roger, > > On 01/28/2015 12:38 AM, Roger Quadros wrote: >> Chanwoo, >> >> On 27/01/15 03:54, Chanwoo Choi wrote: >>> Hi Roger, >>> >>> On 01/27/2015 01:27 AM, Roger Quadros wrote: Hi Chanwoo, All your comments are valid. Need som

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-27 Thread Chanwoo Choi
Hi Roger, On 01/28/2015 12:38 AM, Roger Quadros wrote: > Chanwoo, > > On 27/01/15 03:54, Chanwoo Choi wrote: >> Hi Roger, >> >> On 01/27/2015 01:27 AM, Roger Quadros wrote: >>> Hi Chanwoo, >>> >>> All your comments are valid. Need some clarification on one comment. >>> >>> On 26/01/15 15:56, Chan

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-27 Thread Roger Quadros
Chanwoo, On 27/01/15 03:54, Chanwoo Choi wrote: > Hi Roger, > > On 01/27/2015 01:27 AM, Roger Quadros wrote: >> Hi Chanwoo, >> >> All your comments are valid. Need some clarification on one comment. >> >> On 26/01/15 15:56, Chanwoo Choi wrote: >>> Hi Roger, >>> >>> This patch looks good to me. Bu

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-26 Thread Chanwoo Choi
Hi Roger, On 01/27/2015 01:27 AM, Roger Quadros wrote: > Hi Chanwoo, > > All your comments are valid. Need some clarification on one comment. > > On 26/01/15 15:56, Chanwoo Choi wrote: >> Hi Roger, >> >> This patch looks good to me. But I add some comment. >> If you modify some comment, I'll app

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-26 Thread Roger Quadros
Hi Chanwoo, All your comments are valid. Need some clarification on one comment. On 26/01/15 15:56, Chanwoo Choi wrote: > Hi Roger, > > This patch looks good to me. But I add some comment. > If you modify some comment, I'll apply this patch on 3.21 queue. > > On Mon, Jan 26, 2015 at 9:15 PM, Ro

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-26 Thread Chanwoo Choi
Hi Roger, This patch looks good to me. But I add some comment. If you modify some comment, I'll apply this patch on 3.21 queue. On Mon, Jan 26, 2015 at 9:15 PM, Roger Quadros wrote: > This driver observes the USB ID pin connected over a GPIO and > updates the USB cable extcon states accordingly.