Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

2016-12-03 Thread Jarkko Sakkinen
On Sat, Dec 03, 2016 at 05:32:36PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > > Functions tpm_transmit and transmit_cmd are referenced > > from other functions kdoc hence deserve documentation. > > > > Signed-off-by: Tomas Winkler > > Do you

Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

2016-12-03 Thread Jarkko Sakkinen
On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > Functions tpm_transmit and transmit_cmd are referenced > from other functions kdoc hence deserve documentation. > > Signed-off-by: Tomas Winkler Do you mind if I change TPM_DIGEST_SIZE to SHA1_DIGEST_SIZE? I'm looking to drop TPM_