Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-24 Thread Tycho Andersen
Hi Oleg, On Thu, May 17, 2018 at 05:46:37PM +0200, Oleg Nesterov wrote: > On 05/17, Tycho Andersen wrote: > > > > > From lockdep pov this loop tries to take the same lock twice or more, it > > > shoul > > > complain. > > > > I didn't, but I guess that's because it's not trying to take the same lo

Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-21 Thread Tycho Andersen
On Sat, May 19, 2018 at 01:01:15PM +0800, kbuild test robot wrote: > Hi Tycho, > > I love your patch! Yet something to improve: Whoops, seems I forgot to compile the !CONFIG_SECCOMP_USER_NOTIFICATION case. Anyways, I've fixed this for v3. Tycho

Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-18 Thread kbuild test robot
Hi Tycho, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc5] [cannot apply to next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-18 Thread kbuild test robot
Hi Tycho, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc5] [cannot apply to next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-18 Thread Tycho Andersen
On Fri, May 18, 2018 at 04:04:16PM +0200, Christian Brauner wrote: > On Thu, May 17, 2018 at 09:12:15AM -0600, Tycho Andersen wrote: > > +#ifdef CONFIG_SECCOMP_USER_NOTIFICATION > > +static u64 seccomp_next_notify_id(struct seccomp_filter *filter) > > +{ > > + u64 ret = filter->next_id; > > + > >

Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-18 Thread Christian Brauner
On Thu, May 17, 2018 at 09:12:15AM -0600, Tycho Andersen wrote: > This patch introduces a means for syscalls matched in seccomp to notify > some other task that a particular filter has been triggered. > > The motivation for this is primarily for use with containers. For example, > if a container d

Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-17 Thread Oleg Nesterov
On 05/17, Tycho Andersen wrote: > > > From lockdep pov this loop tries to take the same lock twice or more, it > > shoul > > complain. > > I didn't, but I guess that's because it's not trying to take the same lock > twice -- the pointer cur is changing in the loop. Yes, I see. But this is the sam

Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-17 Thread Tycho Andersen
Hi Oleg, Thanks for taking a look! On Thu, May 17, 2018 at 05:33:24PM +0200, Oleg Nesterov wrote: > I didn't read this series yet, and I don't even understand what are you > trying to do, just one question... > > On 05/17, Tycho Andersen wrote: > > > > +static struct file *init_listener(struct t

Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace

2018-05-17 Thread Oleg Nesterov
I didn't read this series yet, and I don't even understand what are you trying to do, just one question... On 05/17, Tycho Andersen wrote: > > +static struct file *init_listener(struct task_struct *task, > + struct seccomp_filter *filter) > +{ > + struct file *ret