Re: [PATCH v2 1/3] media/videobuf2-dma-sg: Fix handling of sg_table structure

2015-02-13 Thread Ricardo Ribalda Delgado
Hello all On Fri, Feb 13, 2015 at 4:32 PM, Hans Verkuil wrote: > Yes please. And if Ricardo is correct, then someone (janitor job?) should do > a review of dma_unmap_sg in particular. Perhaps a code snippet inside scatterlist.h will clarify even more. Would any of the maintainers accept a patc

Re: [PATCH v2 1/3] media/videobuf2-dma-sg: Fix handling of sg_table structure

2015-02-13 Thread Hans Verkuil
On 02/13/2015 04:20 PM, Ricardo Ribalda Delgado wrote: > Hello Hans > > On Fri, Feb 13, 2015 at 4:02 PM, Hans Verkuil wrote: >> Hi Ricardo, Marek, >> >> I have a few questions, mostly to improve my own understanding. >> >> First of all, is this solving an actual bug for you, or did you just find

Re: [PATCH v2 1/3] media/videobuf2-dma-sg: Fix handling of sg_table structure

2015-02-13 Thread Ricardo Ribalda Delgado
Hello Hans On Fri, Feb 13, 2015 at 4:02 PM, Hans Verkuil wrote: > Hi Ricardo, Marek, > > I have a few questions, mostly to improve my own understanding. > > First of all, is this solving an actual bug for you, or did you just find > it while reviewing code? And if it solves a bug, then which arch

Re: [PATCH v2 1/3] media/videobuf2-dma-sg: Fix handling of sg_table structure

2015-02-13 Thread Hans Verkuil
Hi Ricardo, Marek, I have a few questions, mostly to improve my own understanding. First of all, is this solving an actual bug for you, or did you just find it while reviewing code? And if it solves a bug, then which architecture are you using? ARM? Intel? On 02/11/2015 11:33 AM, Ricardo Ribalda

Re: [PATCH v2 1/3] media/videobuf2-dma-sg: Fix handling of sg_table structure

2015-02-11 Thread Marek Szyprowski
Hello, On 2015-02-11 11:33, Ricardo Ribalda Delgado wrote: When sg_alloc_table_from_pages() does not fail it returns a sg_table structure with nents and nents_orig initialized to the same value. dma_map_sg returns the number of areas mapped by the hardware, which could be different than the are