Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

2020-06-30 Thread Andy Shevchenko
On Tue, Jun 30, 2020 at 7:11 PM Sungbo Eo wrote: > > Thanks for all the reviews! I've updated the patch, please have a look. > > And I have something to ask. > > # echo 1 > gpio408/value > # cat gpio408/value > cat: read error: I/O error > # cat gpio408/direction > out > # echo out > gpio408/direc

Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

2020-06-30 Thread Sungbo Eo
Thanks for all the reviews! I've updated the patch, please have a look. And I have something to ask. # echo 1 > gpio408/value # cat gpio408/value cat: read error: I/O error # cat gpio408/direction out # echo out > gpio408/direction # echo in > gpio408/direction [ 91.006691] gpio-408 (sysfs): g

Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

2020-06-30 Thread Andy Shevchenko
On Tue, Jun 30, 2020 at 12:28 PM Bartosz Golaszewski wrote: > On Thu, Jun 25, 2020 at 9:58 AM Sungbo Eo wrote: > > +static const struct of_device_id pca9570_of_match_table[] = { > > + { .compatible = "nxp,pca9570" }, > > + { /* sentinel */ } > > +}; > > +MODULE_DEVICE_TABLE(of, pca95

Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

2020-06-30 Thread Bartosz Golaszewski
On Thu, Jun 25, 2020 at 9:58 AM Sungbo Eo wrote: > > NXP PCA9570 is 4-bit I2C GPO expander without interrupt functionality. > Its ports are controlled only by a data byte without register address. > > As there is no other driver similar enough to be adapted for it, a new > driver is introduced her

Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

2020-06-25 Thread kernel test robot
Hi Sungbo, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v5.8-rc2 next-20200625] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://g

Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

2020-06-25 Thread kernel test robot
Hi Sungbo, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v5.8-rc2 next-20200625] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://g

Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

2020-06-25 Thread Andy Shevchenko
On Thu, Jun 25, 2020 at 10:59 AM Sungbo Eo wrote: > > NXP PCA9570 is 4-bit I2C GPO expander without interrupt functionality. > Its ports are controlled only by a data byte without register address. > > As there is no other driver similar enough to be adapted for it, a new > driver is introduced he