Re: [PATCH v2 1/2] ASoC: Remove 'const' from the device_node pointers

2014-11-10 Thread Russell King - ARM Linux
On Mon, Nov 10, 2014 at 07:37:04PM +, Mark Brown wrote: > On Sun, Nov 09, 2014 at 08:33:45PM +0100, Jean-Francois Moine wrote: > > > index 7ba7130..405f967 100644 > > --- a/include/sound/soc.h > > +++ b/include/sound/soc.h > > @@ -886,7 +886,7 @@ struct snd_soc_platform_driver { > > > > str

Re: [PATCH v2 1/2] ASoC: Remove 'const' from the device_node pointers

2014-11-10 Thread Mark Brown
On Sun, Nov 09, 2014 at 08:33:45PM +0100, Jean-Francois Moine wrote: > index 7ba7130..405f967 100644 > --- a/include/sound/soc.h > +++ b/include/sound/soc.h > @@ -886,7 +886,7 @@ struct snd_soc_platform_driver { > > struct snd_soc_dai_link_component { > const char *name; > - const str

Re: [PATCH v2 1/2] ASoC: Remove 'const' from the device_node pointers

2014-11-10 Thread Mark Brown
On Mon, Nov 10, 2014 at 08:12:54PM +0100, Jean-Francois Moine wrote: > Mark Brown wrote: > > Did Russell write this patch (in which case it's missing a signoff and > > his e-mail address above) or are you trying to say "Russell King > > said..."? > Sorry, that was "Russell said ...". > Do you wa

Re: [PATCH v2 1/2] ASoC: Remove 'const' from the device_node pointers

2014-11-10 Thread Jean-Francois Moine
On Mon, 10 Nov 2014 19:03:32 + Mark Brown wrote: > On Sun, Nov 09, 2014 at 08:33:45PM +0100, Jean-Francois Moine wrote: > > From Russell King: > > of_node_put() modifies the struct device_node contents. Therefore, > > of_node_put() definitely not treating the data pointed to as read-only, >

Re: [PATCH v2 1/2] ASoC: Remove 'const' from the device_node pointers

2014-11-10 Thread Mark Brown
On Sun, Nov 09, 2014 at 08:33:45PM +0100, Jean-Francois Moine wrote: > From Russell King: > of_node_put() modifies the struct device_node contents. Therefore, > of_node_put() definitely not treating the data pointed to as read-only, > and therefore it is completely inappropriate for it to be marke